issue_comments

Table actions

6 rows where issue = 1661860507 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • GitHub Action to lint Python code with ruff · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1509852821 https://github.com/simonw/datasette/pull/2056#issuecomment-1509852821 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5Z_oaV cclauss 3709715 2023-04-15T14:24:45Z 2023-04-15T14:24:45Z NONE

Status?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506485287 https://github.com/simonw/datasette/pull/2056#issuecomment-1506485287 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5ZyyQn cclauss 3709715 2023-04-13T07:29:38Z 2023-04-13T07:41:55Z NONE

Ruff (written in Rust, not Python) is a 23MB executable so the time to download and pip install it dwarfs its runtime.

Let's run ruff with and without GitHub Actions pip cache side-by-side to see the relative performance.

Once you approve the workflows below, ruff_with_cache should echo cache-hit = false but if you rerun that job hopefully it should echo cache-hit = true. That will be the execution time that we are interested to compare.

There are two great problems in computer science: ;-) 1. Naming things 2. Cache invalidation 3. Off-by-one errors

For 2., https://github.com/actions/setup-python#caching-packages-dependencies is vital reading. Only exactly pinned requirements can be cached. Currently in setup.py the only pinned dependencies are: 1. Sphinx==6.1.3 2. furo==2023.3.27 3. black==23.3.0 4. blacken-docs==1.13.0 # but unpinned elsewhere in setup.py

This means that there will be very few cache hits in the current actions. See the link below to print out cache hits: https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#cache-hit

PyPI uses Fastly's CDN to quickly serve content to end-users, allowing us to minimize our hosting infrastructure and obscure possible downtime. -- https://pypi.org/sponsors

I would be shocked if Fastly does not have beefy CDN nodes in the same datacenters where GitHub Actions run so GHA requests to download ruff probably never hit a PyPI server.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506179555 https://github.com/simonw/datasette/pull/2056#issuecomment-1506179555 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5Zxnnj simonw 9599 2023-04-13T01:21:05Z 2023-04-13T01:22:08Z OWNER

OK, I'm sold - this is a really neat improvement.

One thing to change in the PR: right now it runs pip install --user ruff on every commit, which hits PyPI to install the package.

I prefer to avoid hitting PyPI every time, so I like to use the GitHub Actions cache. My usual pattern for that looks like this:

https://github.com/simonw/datasette/blob/5890a20c374fb0812d88c9b0ef26a838bfa06c76/.github/workflows/test-pyodide.yml#L16-L20

Then a separate command that runs pip install ... will benefit from that cache.

Are you OK to make that change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506177857 https://github.com/simonw/datasette/pull/2056#issuecomment-1506177857 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5ZxnNB simonw 9599 2023-04-13T01:18:18Z 2023-04-13T01:18:18Z OWNER

Cool - and now https://github.com/simonw/datasette/pull/2056/files is showing me those inline annotations:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506177115 https://github.com/simonw/datasette/pull/2056#issuecomment-1506177115 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5ZxnBb simonw 9599 2023-04-13T01:17:16Z 2023-04-13T01:17:16Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506175208 https://github.com/simonw/datasette/pull/2056#issuecomment-1506175208 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5Zxmjo simonw 9599 2023-04-13T01:14:13Z 2023-04-13T01:14:13Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);