home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 1822940263 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 3

issue 1

  • Implement canned queries against new query JSON work · 3 ✖

author_association 1

  • OWNER 3
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1670470516 https://github.com/simonw/datasette/issues/2114#issuecomment-1670470516 https://api.github.com/repos/simonw/datasette/issues/2114 IC_kwDOBm6k_c5jkVt0 simonw 9599 2023-08-09T00:09:55Z 2023-08-09T00:10:32Z OWNER

I decided to figure out where the _size= parameter here comes from: https://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/database.py#L576-L588

It took some spelunking, but it looks like I added that five years ago as part of CSV streaming in https://github.com/simonw/datasette/commit/fc3660cfad7668dbce6ead12766e048fc1f78b11

It's there purely to allow CSV streaming to set _size="max".

And since CSV streaming is still just a table thing, not a query thing, I can drop it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Implement canned queries against new query JSON work 1822940263  
1670454222 https://github.com/simonw/datasette/issues/2114#issuecomment-1670454222 https://api.github.com/repos/simonw/datasette/issues/2114 IC_kwDOBm6k_c5jkRvO simonw 9599 2023-08-08T23:44:42Z 2023-08-08T23:44:42Z OWNER

The tests for this are still passing:

bash pytest tests/test_canned_queries.py Because I left in the old code:

https://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L752-L767

https://github.com/simonw/datasette/blob/cd57b0f71234273156cb1eba3f9153b9e27ac14d/datasette/views/table.py#L701-L727

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Implement canned queries against new query JSON work 1822940263  
1652321419 https://github.com/simonw/datasette/issues/2114#issuecomment-1652321419 https://api.github.com/repos/simonw/datasette/issues/2114 IC_kwDOBm6k_c5ifGyL simonw 9599 2023-07-26T18:48:03Z 2023-07-26T18:48:03Z OWNER

This is also where I'll bring back writable canned queries:

https://github.com/simonw/datasette/blob/18dd88ee4d78fe9d760e9da96028ae06d938a85c/datasette/views/database.py#L281-L334

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Implement canned queries against new query JSON work 1822940263  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 21.819ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows