issue_comments

Table actions

2 rows where issue = 1865869205 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 2 ✖

issue 1

  • Proposal: Make the `_internal` database persistent, customizable, and hidden · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1692465763 https://github.com/simonw/datasette/issues/2157#issuecomment-1692465763 https://api.github.com/repos/simonw/datasette/issues/2157 IC_kwDOBm6k_c5k4Ppj simonw 9599 2023-08-24T21:54:29Z 2023-08-24T21:54:29Z OWNER

But yes, I'm a big +1 on this whole plan.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Proposal: Make the `_internal` database persistent, customizable, and hidden 1865869205  
1692465334 https://github.com/simonw/datasette/issues/2157#issuecomment-1692465334 https://api.github.com/repos/simonw/datasette/issues/2157 IC_kwDOBm6k_c5k4Pi2 simonw 9599 2023-08-24T21:54:09Z 2023-08-24T21:54:09Z OWNER

We discussed this in-person this morning and these notes reflect what we talked about perfectly.

I've had so many bugs with plugins that I've written myself that have forgotten to special-case the _internal database when looping through datasette.databases.keys() - removing it from there entirely would help a lot.

Just one tiny disagreement: for datasette-comments I think having it store things in _internal could be an option, but in most cases I expect users to chose NOT to do that - because being able to join against those tables for more advanced queries is going to be super useful.

Show me all rows in foia_requests with at least one associated comment in datasette_comments.comments kind of tihng.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Proposal: Make the `_internal` database persistent, customizable, and hidden 1865869205  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);