issue_comments

Table actions

4 rows where issue = 272391665 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Switch to ujson · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
504883688 https://github.com/simonw/datasette/issues/48#issuecomment-504883688 https://api.github.com/repos/simonw/datasette/issues/48 MDEyOklzc3VlQ29tbWVudDUwNDg4MzY4OA== simonw 9599 2019-06-24T06:57:43Z 2019-06-24T06:57:43Z OWNER

I've seen no evidence that JSON handling is even close to being a performance bottleneck, so wontfix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Switch to ujson 272391665  
379556637 https://github.com/simonw/datasette/issues/48#issuecomment-379556637 https://api.github.com/repos/simonw/datasette/issues/48 MDEyOklzc3VlQ29tbWVudDM3OTU1NjYzNw== simonw 9599 2018-04-08T14:56:52Z 2018-04-08T14:56:52Z OWNER

It would be useful to have a microbenchmark in place to help understand how much of a performance benefit this would actually provide.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Switch to ujson 272391665  
343239062 https://github.com/simonw/datasette/issues/48#issuecomment-343239062 https://api.github.com/repos/simonw/datasette/issues/48 MDEyOklzc3VlQ29tbWVudDM0MzIzOTA2Mg== simonw 9599 2017-11-09T18:01:46Z 2017-11-09T18:01:46Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Switch to ujson 272391665  
343168796 https://github.com/simonw/datasette/issues/48#issuecomment-343168796 https://api.github.com/repos/simonw/datasette/issues/48 MDEyOklzc3VlQ29tbWVudDM0MzE2ODc5Ng== simonw 9599 2017-11-09T14:22:21Z 2017-11-09T14:22:21Z OWNER

Won't fix: ujson is not compatible with the custom JSON encoder I'm using here: https://github.com/simonw/immutabase/blob/b2dee11fcd989d9e2a7bf4de1e23dbc320c05013/immutabase/app.py#L401-L416

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Switch to ujson 272391665  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);