home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

12 rows where issue = 274615452 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • simonw 12

issue 1

  • Add “updated” to metadata · 12 ✖

author_association 1

  • OWNER 12
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
924437942 https://github.com/simonw/datasette/issues/111#issuecomment-924437942 https://api.github.com/repos/simonw/datasette/issues/111 IC_kwDOBm6k_c43Gc22 simonw 9599 2021-09-21T22:32:59Z 2021-09-21T22:47:07Z OWNER

Side-note: Django 4.0 will switch from using pytz to using the standard library zoneinfo module introduced in Python 3.9, which has a backport that works as far back as 3.6: https://github.com/pganssle/zoneinfo (https://pypi.org/project/backports.zoneinfo/)

If I need to handle timezones I'll use that, but I think I can get away without it?

Django does this: https://github.com/django/django/blob/b0ed619303d2fb723330ca9efa3acf23d49f1d19/setup.cfg#L39-L43

install_requires = asgiref >= 3.3.2 backports.zoneinfo; python_version<"3.9" sqlparse >= 0.2.2 tzdata; sys_platform == 'win32'

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
924443089 https://github.com/simonw/datasette/issues/111#issuecomment-924443089 https://api.github.com/repos/simonw/datasette/issues/111 IC_kwDOBm6k_c43GeHR simonw 9599 2021-09-21T22:45:14Z 2021-09-21T22:45:26Z OWNER

The audiences I care about here are:

  • Producers of this timestamp - generally that will be users who are using datasette publish to share their data
  • Human consumers of this timestamp - end users who look at a Datasette site and want to know how recent the data is
  • Machine consumers of this timestamp - API integrations that might want to check if a Datasette instance has been updated before downloading new data

For producers I think there are going to be two categories. The first is users who run "publish" and want the site to reflect when they did so (probably using --updated=now when they publish). The second are users who are willing to spend more time thinking about this - for example my various git scraping projects where I want to use a date derived from the git history.

For humans... I'd like to be able to calculate a relative time (3 hours ago) in addition to showing the display time, because that helps avoid confusion over timezones.

For machine consumers, it might be nice to offer the option of a calculated Unix timestamp-since-1970, since those can be easier to work with in some languages than running a full ISO date parser.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
924438481 https://github.com/simonw/datasette/issues/111#issuecomment-924438481 https://api.github.com/repos/simonw/datasette/issues/111 IC_kwDOBm6k_c43Gc_R simonw 9599 2021-09-21T22:34:03Z 2021-09-21T22:34:21Z OWNER

The simplest possible version of this: it's always represented as a UTC ISO datetime, like this:

"updated": "2020-10-31T12:00:00+00:00"

Later versions of Datasette could extend this to handle other timezones or support just the date (though that's a backwards incompatible change so probably better to decide on the date thing right now).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
924435971 https://github.com/simonw/datasette/issues/111#issuecomment-924435971 https://api.github.com/repos/simonw/datasette/issues/111 IC_kwDOBm6k_c43GcYD simonw 9599 2021-09-21T22:29:15Z 2021-09-21T22:29:49Z OWNER

So this is a metadata key called updated which can be applied at the table, database or instance level. It is represented as a .isoformat() timestamp.

Question: should I support just the date - yyyy-mm-dd - in addition to the datetime?

I think so. I can easily imagine situations where the exact time of day that a change was made hasn't been recorded, but the overall date is known.

But in that case, should the updated key sometimes be yyyy-mm-dd and sometimes be the full isoformat datetime? Or should there be an updated_date key that's used for just the date?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
924432643 https://github.com/simonw/datasette/issues/111#issuecomment-924432643 https://api.github.com/repos/simonw/datasette/issues/111 IC_kwDOBm6k_c43GbkD simonw 9599 2021-09-21T22:23:23Z 2021-09-21T22:23:23Z OWNER

I'm going to use https://github.com/dateutil/dateutil for this - it's been maintained constantly (by an evolving team of contributors) since 2003 and is a very trustworthy dependency.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
923106887 https://github.com/simonw/datasette/issues/111#issuecomment-923106887 https://api.github.com/repos/simonw/datasette/issues/111 IC_kwDOBm6k_c43BX5H simonw 9599 2021-09-20T16:58:39Z 2021-09-20T16:58:39Z OWNER

Still a good idea today too! Would be great for https://cdc-vaccination-history.datasette.io/ for example.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
738904347 https://github.com/simonw/datasette/issues/111#issuecomment-738904347 https://api.github.com/repos/simonw/datasette/issues/111 MDEyOklzc3VlQ29tbWVudDczODkwNDM0Nw== simonw 9599 2020-12-04T17:16:56Z 2020-12-04T17:16:56Z OWNER

This is STILL a good idea.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
697545290 https://github.com/simonw/datasette/issues/111#issuecomment-697545290 https://api.github.com/repos/simonw/datasette/issues/111 MDEyOklzc3VlQ29tbWVudDY5NzU0NTI5MA== simonw 9599 2020-09-23T15:29:11Z 2020-09-23T15:29:11Z OWNER

This is still a good idea.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
502135123 https://github.com/simonw/datasette/issues/111#issuecomment-502135123 https://api.github.com/repos/simonw/datasette/issues/111 MDEyOklzc3VlQ29tbWVudDUwMjEzNTEyMw== simonw 9599 2019-06-14T14:39:59Z 2019-06-14T14:39:59Z OWNER

This may be the feature that causes me to add dateutilas a dependency (so I can use dateutil.parser.parse)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
502134699 https://github.com/simonw/datasette/issues/111#issuecomment-502134699 https://api.github.com/repos/simonw/datasette/issues/111 MDEyOklzc3VlQ29tbWVudDUwMjEzNDY5OQ== simonw 9599 2019-06-14T14:38:58Z 2019-06-14T14:38:58Z OWNER

I think I'll just call it "updated" to avoid the ugly underscore.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
502134167 https://github.com/simonw/datasette/issues/111#issuecomment-502134167 https://api.github.com/repos/simonw/datasette/issues/111 MDEyOklzc3VlQ29tbWVudDUwMjEzNDE2Nw== simonw 9599 2019-06-14T14:37:35Z 2019-06-14T14:37:35Z OWNER

We have per-database and per-table metadata now. I think it's time to make this actually happen.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  
345013127 https://github.com/simonw/datasette/issues/111#issuecomment-345013127 https://api.github.com/repos/simonw/datasette/issues/111 MDEyOklzc3VlQ29tbWVudDM0NTAxMzEyNw== simonw 9599 2017-11-16T18:23:56Z 2017-11-16T18:23:56Z OWNER

Having this as a global option may not make sense when publishing multiple databases. We can revisit that when we implement per-database and per-table metadata.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add “updated” to metadata 274615452  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 22.329ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows