issue_comments

Table actions

8 rows where issue = 278208011 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Ability to bundle and serve additional static files · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
459915995 https://github.com/simonw/datasette/issues/160#issuecomment-459915995 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDQ1OTkxNTk5NQ== psychemedia 82988 2019-02-02T00:43:16Z 2019-02-02T00:58:20Z CONTRIBUTOR

Do you have any simple working examples of how to use --static? Inspection of default served files suggests locations such as http://example.com/-/static/app.css?0e06ee.

If datasette is being proxied to http://example.com/foo/datasette, what form should arguments to --static take so that static files are correctly referenced?

Use case is here: https://github.com/psychemedia/jupyterserverproxy-datasette-demo Trying to do a really simple datasette demo in MyBinder using jupyter-server-proxy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
350496258 https://github.com/simonw/datasette/issues/160#issuecomment-350496258 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM1MDQ5NjI1OA== simonw 9599 2017-12-09T18:29:28Z 2017-12-09T18:29:28Z OWNER

Example usage:

datasette package --static css:extra-css/ --static js:extra-js/ \
    sf-trees.db --template-dir templates/ --tag sf-trees --branch master

This creates a local Docker image that includes copies of the templates/, extra-css/ and extra-js/ directories. You can then run it like this:

docker run -p 8001:8001 sf-trees

For publishing to Zeit now:

datasette publish now --static css:extra-css/ --static js:extra-js/ \
    sf-trees.db --template-dir templates/ --name sf-trees --branch master

Example: https://sf-trees-wbihszoazc.now.sh/sf-trees-02c8ef1/Street_Tree_List

For publishing to Heroku:

datasette publish heroku --static css:extra-css/ --static js:extra-js/ \
    sf-trees.db --template-dir templates/ --branch master

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
348793156 https://github.com/simonw/datasette/issues/160#issuecomment-348793156 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM0ODc5MzE1Ng== simonw 9599 2017-12-03T16:35:53Z 2017-12-03T16:35:53Z OWNER

Still TODO: teach datasette publish and friends about this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
348793054 https://github.com/simonw/datasette/issues/160#issuecomment-348793054 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM0ODc5MzA1NA== simonw 9599 2017-12-03T16:35:22Z 2017-12-03T16:35:22Z OWNER

You can now tell Datasette to serve static files from a specific location at a specific mountpoint.

For example:

datasette serve mydb.db --static extra-css:/tmp/static/css

Now if you visit this URL:

http://localhost:8001/extra-css/blah.css

The following file will be served:

/tmp/static/css/blah.css

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
348719827 https://github.com/simonw/datasette/issues/160#issuecomment-348719827 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM0ODcxOTgyNw== simonw 9599 2017-12-02T21:01:36Z 2017-12-02T21:01:36Z OWNER

-m is already taken for --metadata.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
348719752 https://github.com/simonw/datasette/issues/160#issuecomment-348719752 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM0ODcxOTc1Mg== simonw 9599 2017-12-02T21:00:21Z 2017-12-02T21:00:21Z OWNER

Not sure which I like better out of -d/--docroot or -s/--static or -m/--mount for this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
348719680 https://github.com/simonw/datasette/issues/160#issuecomment-348719680 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM0ODcxOTY4MA== simonw 9599 2017-12-02T20:59:27Z 2017-12-02T20:59:27Z OWNER

This is about more than just CSS and JavaScript - there are plenty of reasons someone might want to bundle HTML as well, e.g. for building something like https://sf-tree-search.now.sh/

So, instead of thinking about this in terms of /static/, I'm going to think about this in terms of allowing people to mount one or more document roots (or docroots).

datasette serve mydb.db -d my-doc-root/

This will cause the root of the server to show content from the my-doc-root/ directory (assuming it has an index.html file in it).

A more common option will be to mount specific folders to specific directories, like this:

datasette serve mydb.db -d static:my-static/

Now any hits to /static/foo.css will serve content from my-static/foo.css

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  
348404864 https://github.com/simonw/datasette/issues/160#issuecomment-348404864 https://api.github.com/repos/simonw/datasette/issues/160 MDEyOklzc3VlQ29tbWVudDM0ODQwNDg2NA== simonw 9599 2017-12-01T05:26:57Z 2017-12-01T05:26:57Z OWNER

Question is... what should happen to the default static stuff? At the moment that's just https://fivethirtyeight.datasettes.com/-/static/app.css - though I want to improve that to include a content hash, see #154 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle and serve additional static files 278208011  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);