issue_comments

Table actions

6 rows where issue = 280315352 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Nasty bug: last column not being correctly displayed · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
350516782 https://github.com/simonw/datasette/issues/167#issuecomment-350516782 https://api.github.com/repos/simonw/datasette/issues/167 MDEyOklzc3VlQ29tbWVudDM1MDUxNjc4Mg== simonw 9599 2017-12-10T00:48:54Z 2017-12-10T00:48:54Z OWNER

I can simplify this all by dropping the nicety where if a table is using a rowid the Link column is titled rowid instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Nasty bug: last column not being correctly displayed 280315352  
350515985 https://github.com/simonw/datasette/issues/167#issuecomment-350515985 https://api.github.com/repos/simonw/datasette/issues/167 MDEyOklzc3VlQ29tbWVudDM1MDUxNTk4NQ== simonw 9599 2017-12-10T00:28:39Z 2017-12-10T00:28:39Z OWNER

A better alternative:

async def display_columns_and_rows(self, database, table, rows, link_column=False):

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Nasty bug: last column not being correctly displayed 280315352  
350515616 https://github.com/simonw/datasette/issues/167#issuecomment-350515616 https://api.github.com/repos/simonw/datasette/issues/167 MDEyOklzc3VlQ29tbWVudDM1MDUxNTYxNg== simonw 9599 2017-12-10T00:21:58Z 2017-12-10T00:21:58Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Nasty bug: last column not being correctly displayed 280315352  
350424595 https://github.com/simonw/datasette/issues/167#issuecomment-350424595 https://api.github.com/repos/simonw/datasette/issues/167 MDEyOklzc3VlQ29tbWVudDM1MDQyNDU5NQ== simonw 9599 2017-12-09T05:08:27Z 2017-12-09T05:08:27Z OWNER

Perhaps the row.html and table.html templates should be passed the same data but should themselves decide if they will display the Link column 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Nasty bug: last column not being correctly displayed 280315352  
350421661 https://github.com/simonw/datasette/issues/167#issuecomment-350421661 https://api.github.com/repos/simonw/datasette/issues/167 MDEyOklzc3VlQ29tbWVudDM1MDQyMTY2MQ== simonw 9599 2017-12-09T03:52:46Z 2017-12-09T03:52:46Z OWNER

Input: results from the database, foreign key definitions, primary key definitions, type of page

Output: display_columns and display_rows

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Nasty bug: last column not being correctly displayed 280315352  
350125953 https://github.com/simonw/datasette/issues/167#issuecomment-350125953 https://api.github.com/repos/simonw/datasette/issues/167 MDEyOklzc3VlQ29tbWVudDM1MDEyNTk1Mw== simonw 9599 2017-12-07T23:25:28Z 2017-12-07T23:25:28Z OWNER

My column/row HTML display logic has got way too convoluted. This is a sign I need to add proper unit tests for it and clean it up.

The complexity comes from:

  • Displaying a rowid for tables that do not have a primary key
  • Showing an additional Link column for rows with a primary key
  • Not displaying that Link column on the individual row pages
  • Trying to get foreign keys working correctly in all cases, e.g. #152 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Nasty bug: last column not being correctly displayed 280315352  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);