issue_comments

Table actions

7 rows where issue = 323223872 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Validate metadata.json on startup · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1600778057 https://github.com/simonw/datasette/issues/260#issuecomment-1600778057 https://api.github.com/repos/simonw/datasette/issues/260 IC_kwDOBm6k_c5fae9J simonw 9599 2023-06-21T12:51:22Z 2023-06-21T12:51:22Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Validate metadata.json on startup 323223872  
1235785955 https://github.com/simonw/datasette/issues/260#issuecomment-1235785955 https://api.github.com/repos/simonw/datasette/issues/260 IC_kwDOBm6k_c5JqJjj simonw 9599 2022-09-02T18:18:06Z 2022-09-02T18:18:06Z OWNER

Did some related research work in this issue: - https://github.com/simonw/shot-scraper/issues/28

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Validate metadata.json on startup 323223872  
1235079469 https://github.com/simonw/datasette/issues/260#issuecomment-1235079469 https://api.github.com/repos/simonw/datasette/issues/260 IC_kwDOBm6k_c5JndEt zaneselvans 596279 2022-09-02T05:24:59Z 2022-09-02T05:24:59Z NONE

@zschira is working with Pydantic while converting between and validating JSON frictionless datapackage descriptors that annotate an SQLite DB (extracted from FERC's XBRL data) and the Datasette YAML metadata so we can publish them with Datasette. Maybe there's some overlap? We've been loving Pydantic.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
 Validate metadata.json on startup 323223872  
1234927627 https://github.com/simonw/datasette/issues/260#issuecomment-1234927627 https://api.github.com/repos/simonw/datasette/issues/260 IC_kwDOBm6k_c5Jm4AL simonw 9599 2022-09-02T00:05:43Z 2022-09-02T00:05:43Z OWNER

I'm inclined to consider Pydantic for this, since it is widely used now and can generate really good error messages.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Validate metadata.json on startup 323223872  
1234926923 https://github.com/simonw/datasette/issues/260#issuecomment-1234926923 https://api.github.com/repos/simonw/datasette/issues/260 IC_kwDOBm6k_c5Jm31L simonw 9599 2022-09-02T00:04:26Z 2022-09-02T00:04:45Z OWNER

Interesting example of why this would be valuable here: - https://github.com/simonw/datasette/issues/1798

This YAML file: ```yaml title: Some title description_html: |-

This is an experiment.

databases: off: tables: products_from_owners: title: products_from_owners Was loaded as equivalent to this JSON:json { "title": "Some title", "description_html": "

This is an experiment.

", "databases": { "false": { "tables": { "products_from_owners": { "title": "products_from_owners" } } } } } ``` Validation that caught this would have been useful.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Validate metadata.json on startup 323223872  
1051473892 https://github.com/simonw/datasette/issues/260#issuecomment-1051473892 https://api.github.com/repos/simonw/datasette/issues/260 IC_kwDOBm6k_c4-rDfk zaneselvans 596279 2022-02-26T02:24:15Z 2022-02-26T02:24:15Z NONE

Is there already functionality that can be used to validate the metadata.json file? Is there a JSON Schema that defines it? Or a validation that's available via datasette with Python? We're working on automatically building the metadata in CI and when we deploy to cloud run, and it would be nice to be able to check whether the the metadata we're outputting is valid in our tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Validate metadata.json on startup 323223872  
544318517 https://github.com/simonw/datasette/issues/260#issuecomment-544318517 https://api.github.com/repos/simonw/datasette/issues/260 MDEyOklzc3VlQ29tbWVudDU0NDMxODUxNw== simonw 9599 2019-10-21T01:48:24Z 2019-10-21T01:48:24Z OWNER

This came up in #588 - it would be helpful if this would spot things like "queries" defined against the tables block when they should be defined against a database.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Validate metadata.json on startup 323223872  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);