issue_comments

Table actions

2 rows where issue = 324836533 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Refactor inspect logic · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
390804333 https://github.com/simonw/datasette/pull/277#issuecomment-390804333 https://api.github.com/repos/simonw/datasette/issues/277 MDEyOklzc3VlQ29tbWVudDM5MDgwNDMzMw== simonw 9599 2018-05-21T22:40:16Z 2018-05-21T22:43:50Z OWNER

We should merge this before refactoring the tests though, because that way we don't couple the new tests to the verification of this change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor inspect logic 324836533  
390707183 https://github.com/simonw/datasette/pull/277#issuecomment-390707183 https://api.github.com/repos/simonw/datasette/issues/277 MDEyOklzc3VlQ29tbWVudDM5MDcwNzE4Mw== simonw 9599 2018-05-21T16:28:39Z 2018-05-21T16:28:39Z OWNER

This is definitely a big improvement.

I'd like to refactor the unit tests that cover .inspect() too - currently they are a huge ugly blob at the top of test_api.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor inspect logic 324836533  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);