home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where issue = 395236066 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

  • simonw 5
  • ltrgoddard 1

author_association 2

  • OWNER 5
  • NONE 1

issue 1

  • CSV export in "Advanced export" pane doesn't respect query · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
451415063 https://github.com/simonw/datasette/issues/393#issuecomment-451415063 https://api.github.com/repos/simonw/datasette/issues/393 MDEyOklzc3VlQ29tbWVudDQ1MTQxNTA2Mw== ltrgoddard 1727065 2019-01-04T11:04:08Z 2019-01-04T11:04:08Z NONE

Awesome - will get myself up and running on 0.26

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
CSV export in "Advanced export" pane doesn't respect query 395236066  
451047426 https://github.com/simonw/datasette/issues/393#issuecomment-451047426 https://api.github.com/repos/simonw/datasette/issues/393 MDEyOklzc3VlQ29tbWVudDQ1MTA0NzQyNg== simonw 9599 2019-01-03T03:19:04Z 2019-01-03T03:19:04Z OWNER

https://fivethirtyeight.datasettes.com/-/versions is now running 0.26 - so your initial bug demo is now fixed: https://fivethirtyeight.datasettes.com/fivethirtyeight-c300360/classic-rock%2Fclassic-rock-song-list?Release+Year__exact=1989#export

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
CSV export in "Advanced export" pane doesn't respect query 395236066  
451046123 https://github.com/simonw/datasette/issues/393#issuecomment-451046123 https://api.github.com/repos/simonw/datasette/issues/393 MDEyOklzc3VlQ29tbWVudDQ1MTA0NjEyMw== simonw 9599 2019-01-03T03:05:07Z 2019-01-03T03:05:07Z OWNER

The fix was released as part of Datasette 0.26 - you can see the fix working here: https://v0-26.datasette.io/fixtures-dd88475/facetable?_facet=planet_int&planet_int=1#export

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
CSV export in "Advanced export" pane doesn't respect query 395236066  
450944166 https://github.com/simonw/datasette/issues/393#issuecomment-450944166 https://api.github.com/repos/simonw/datasette/issues/393 MDEyOklzc3VlQ29tbWVudDQ1MDk0NDE2Ng== simonw 9599 2019-01-02T18:32:12Z 2019-01-02T18:32:12Z OWNER

Here's the test that needs updating:

https://github.com/simonw/datasette/blob/8b8ae55e7c8b9e1dceef53f55a330b596ca44d41/tests/test_html.py#L427-L435

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
CSV export in "Advanced export" pane doesn't respect query 395236066  
450943632 https://github.com/simonw/datasette/issues/393#issuecomment-450943632 https://api.github.com/repos/simonw/datasette/issues/393 MDEyOklzc3VlQ29tbWVudDQ1MDk0MzYzMg== simonw 9599 2019-01-02T18:30:20Z 2019-01-02T18:30:20Z OWNER

This is the code which is meant to add those options as hidden form fields:

https://github.com/simonw/datasette/blob/fe5b6ea95a973534fe8a44907c0ea2449aae7602/datasette/templates/table.html#L150-L155

It's clearly not working. Need to fix this and add a corresponding unit test.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
CSV export in "Advanced export" pane doesn't respect query 395236066  
450943172 https://github.com/simonw/datasette/issues/393#issuecomment-450943172 https://api.github.com/repos/simonw/datasette/issues/393 MDEyOklzc3VlQ29tbWVudDQ1MDk0MzE3Mg== simonw 9599 2019-01-02T18:28:43Z 2019-01-02T18:28:43Z OWNER

Definitely a bug, thanks.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
CSV export in "Advanced export" pane doesn't respect query 395236066  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 66.926ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows