issue_comments

Table actions

4 rows where issue = 432893491 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Refactor facets to a class and new plugin, refs #427 · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
488874364 https://github.com/simonw/datasette/pull/432#issuecomment-488874364 https://api.github.com/repos/simonw/datasette/issues/432 MDEyOklzc3VlQ29tbWVudDQ4ODg3NDM2NA== simonw 9599 2019-05-03T00:04:23Z 2019-05-03T00:04:23Z OWNER

Abandoning this in favour of #445 - which contains the code from this branch but updated to incorporate recent changes in master.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor facets to a class and new plugin, refs #427 432893491  
488595724 https://github.com/simonw/datasette/pull/432#issuecomment-488595724 https://api.github.com/repos/simonw/datasette/issues/432 MDEyOklzc3VlQ29tbWVudDQ4ODU5NTcyNA== russss 45057 2019-05-02T08:50:53Z 2019-05-02T08:50:53Z CONTRIBUTOR

Can I pull those needs out of the Facet class somehow?

I was thinking that it might be handy for datasette to have a request object which wraps the Sanic Request. This could include the datasette-specific querystring decoding and the special_args parsing from TableView.data.

This would mean that we could expose the request object to plugin hooks without coupling them to Sanic.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor facets to a class and new plugin, refs #427 432893491  
484584234 https://github.com/simonw/datasette/pull/432#issuecomment-484584234 https://api.github.com/repos/simonw/datasette/issues/432 MDEyOklzc3VlQ29tbWVudDQ4NDU4NDIzNA== simonw 9599 2019-04-18T16:33:52Z 2019-04-18T16:33:52Z OWNER

It would be nice to decouple the request object from the Facet class. The request is needed for two things at the moment:

  • To decide if a specific facet bucket has been selected or not
  • To construct the toggle_url for turning the selection on or off

Can I pull those needs out of the Facet class somehow?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor facets to a class and new plugin, refs #427 432893491  
482876432 https://github.com/simonw/datasette/pull/432#issuecomment-482876432 https://api.github.com/repos/simonw/datasette/issues/432 MDEyOklzc3VlQ29tbWVudDQ4Mjg3NjQzMg== simonw 9599 2019-04-13T20:06:32Z 2019-04-13T20:06:32Z OWNER

This has a bug which isn't being caught by the unit tests (yet) - facet suggestion suggests facets that have already been enabled:

There is also a test failure due to missing plugin hook documentation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor facets to a class and new plugin, refs #427 432893491  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);