issue_comments

Table actions

7 rows where issue = 449886319 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Rename metadata.json to config.json · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1689128911 https://github.com/simonw/datasette/issues/493#issuecomment-1689128911 https://api.github.com/repos/simonw/datasette/issues/493 IC_kwDOBm6k_c5krg_P simonw 9599 2023-08-23T01:29:20Z 2023-08-23T01:29:20Z OWNER

It's going to be called datasette.json and the concept of metadata will be split out separately. See:

  • 2149

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
748305976 https://github.com/simonw/datasette/issues/493#issuecomment-748305976 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDc0ODMwNTk3Ng== jefftriplett 50527 2020-12-18T20:34:39Z 2020-12-18T20:34:39Z CONTRIBUTOR

I can't keep up with the renaming contexts, but I like having the ability to run datasette+ datasette-ripgrep against different configs:

shell datasette serve --metadata=./metadata.json

I have one for all of my code and one per client who has lots of code. So as long as I can point to datasette to something, it's easy to work with. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
747966232 https://github.com/simonw/datasette/issues/493#issuecomment-747966232 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDc0Nzk2NjIzMg== simonw 9599 2020-12-18T09:19:41Z 2020-12-18T09:19:41Z OWNER

Is there any reason to keep --setting rather than moving those items into a configure.json file with all the configuration options that currently live in metadata.json?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
735281577 https://github.com/simonw/datasette/issues/493#issuecomment-735281577 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDczNTI4MTU3Nw== jefftriplett 50527 2020-11-28T19:39:53Z 2020-11-28T19:39:53Z CONTRIBUTOR

I was confused by --config and I tried passing the json from datasette-ripgrep into config.json just as a wild guess.

A short term solution might be pointing out in plugins that their snippet json can go in metadata.json at least makes it easier to search for config options or to know where to start if someone is new. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
640924558 https://github.com/simonw/datasette/issues/493#issuecomment-640924558 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDY0MDkyNDU1OA== simonw 9599 2020-06-08T22:40:01Z 2020-06-08T22:40:01Z OWNER

I'll also rename --config to --setting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
640924482 https://github.com/simonw/datasette/issues/493#issuecomment-640924482 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDY0MDkyNDQ4Mg== simonw 9599 2020-06-08T22:39:45Z 2020-06-08T22:39:45Z OWNER

I'm definitely doing this rename, now that metadata.json is used for allow permissions configuration as well as-of #811.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  
566265079 https://github.com/simonw/datasette/issues/493#issuecomment-566265079 https://api.github.com/repos/simonw/datasette/issues/493 MDEyOklzc3VlQ29tbWVudDU2NjI2NTA3OQ== simonw 9599 2019-12-16T22:04:05Z 2019-12-16T22:04:05Z OWNER

This is particularly relevant as plugins increasingly use metadata.json for their plugin configuration: https://datasette.readthedocs.io/en/0.32/plugins.html#plugin-configuration

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename metadata.json to config.json 449886319  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);