issue_comments

This could play havoc with unmerged PRs. I should merge any big ones (like the JavaScript plugins work) first.

Thinking about this again today. Posted about it on Discord: https://discord.com/channels/823971286308356157/823971286941302908/1143729300349132933

I won't enforce it in a pytest test, I'll enforce it with a CI lint check that's also in the Justfile here instead:

https://github.com/simonw/datasette/blob/17ec309e14f9c2e90035ba33f2f38ecc5afba2fa/Justfile#L19-L23

Browse this commit to see the result: https://github.com/simonw/datasette/tree/59a5d336bd4336bc53103922ada4bf726f4336c9

I just tried this again today by dropping this into .isort.cfg: ini [settings] multi_line_output=3 include_trailing_comma=True force_grid_wrap=0 use_parentheses=True line_length=88 known_first_party=datasette And running this in the root of the project: isort . It produced a huge diff, but when I ran the tests: bash pytest -n auto The tests all passed. I'll push a PR.

The Starlette lint and test scripts do this, and also apply autoflake to remove any unnecessary imports: https://github.com/encode/starlette/tree/8c8cc2ec0a5cb834a9a15b871ae8b480503abb67/scripts

I'm going to resist the temptation to do this until I've merged the asgi branch from #272

This test added do test_black.py seems to do the trick: python @pytest.mark.parametrize("path", code_root.glob("**/*.py")) def test_isort(path): # Have to capture stdout because isort uses print() directly stdout = sys.stdout sys.stdout = io.StringIO() result = isort.SortImports(path, check=True) assert ( not result.incorrectly_sorted ), "{} has incorrectly sorted imports, fix with 'isort -rc . && black .'" sys.stdout = stdout I'll rename test_black.py to test_lint.py to reflect that it now covers more forms of linting.

Also needed: add move_to_front(items, "test_isort") to conftest.py. And add isort to extras_require in setup.py.

According to the black documentation the following config file is necessary to avoid isort and black getting into an edit war with each other: [settings] multi_line_output=3 include_trailing_comma=True force_grid_wrap=0 use_parentheses=True line_length=88