issue_comments

Table actions

4 rows where issue = 459590021 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Decide what goes into Datasette 1.0 · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
969433734 https://github.com/simonw/datasette/issues/519#issuecomment-969433734 https://api.github.com/repos/simonw/datasette/issues/519 IC_kwDOBm6k_c45yGKG simonw 9599 2021-11-15T23:26:11Z 2021-11-15T23:26:11Z OWNER

I'm happy with this as the goals for 1.0. I'm going to close this issue and create three tracking tickets for the three key themes:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Decide what goes into Datasette 1.0 459590021  
691566247 https://github.com/simonw/datasette/issues/519#issuecomment-691566247 https://api.github.com/repos/simonw/datasette/issues/519 MDEyOklzc3VlQ29tbWVudDY5MTU2NjI0Nw== simonw 9599 2020-09-12T22:48:53Z 2020-09-12T22:48:53Z OWNER

I think I've figured out what to do about stability of the HTML and the default templates with respect to semantic versioning.

I'm going to announce that the JSON API - including the variables made available to templates - should be considered stable according to semver. I will only break backwards compatibility at that level in a major version release.

The template HTML (and default CSS) will not be considered a stable interface. They won't change on bug fix releases but they may change (albeit described in the release notes) on minor version bumps.

Since the template inputs are stable, you can run your own copy of the previous version's templates if something breaks.

This means users (and plugin authors) who make changes to the default Datasette UI will have to test their changes against every minor release. I think that's OK.

If you write plugins that don't affect the Datasette HTML UI you will be able to expect stability across minor version releases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Decide what goes into Datasette 1.0 459590021  
636329468 https://github.com/simonw/datasette/issues/519#issuecomment-636329468 https://api.github.com/repos/simonw/datasette/issues/519 MDEyOklzc3VlQ29tbWVudDYzNjMyOTQ2OA== simonw 9599 2020-05-30T13:14:52Z 2020-05-30T13:21:03Z OWNER

I've made a lot of progress towards this recently:

  • Started internals documentation #576
  • Improved design of the request object #706
  • Redesigned register_output_renderer plugin hook #581
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Decide what goes into Datasette 1.0 459590021  
636330023 https://github.com/simonw/datasette/issues/519#issuecomment-636330023 https://api.github.com/repos/simonw/datasette/issues/519 MDEyOklzc3VlQ29tbWVudDYzNjMzMDAyMw== simonw 9599 2020-05-30T13:19:24Z 2020-05-30T13:19:24Z OWNER

Goals for Datasette 1.0:

  • Generally signify confidence in the quality/stability of Datasette. I think I'm there already.
  • Plugin authors can have confidence that their plugins will work for the whole 1.x release cycle
  • Developers building against Datasette JSON APIs should have confidence in 1.x compatibility
  • Template authors and CSS theme authors should have that confidence too

I think I'm very nearly there for the plugin API. The harder ones are JSON APIs and template authors.

For JSON APIs: The default JSON just isn't right. I find myself using ?_shape=array for almost everything I build.

The template part is harder. I think I need to fully document the template variables for every view - and add protective unit tests that match that documentation.

The CSS theme part is so hard it may not be possible. How do you guarantee stable HTML that won't break with custom CSS when you'll be adding new features during the 1.x release run? The pattern portfolio from #151 should hopefully help a lot there, but I still don't have a complete idea of what this entails or how feasible it is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Decide what goes into Datasette 1.0 459590021  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);