issue_comments

Table actions

2 rows where issue = 459627549 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Show total/unfiltered row count when filtering · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
504809397 https://github.com/simonw/datasette/issues/523#issuecomment-504809397 https://api.github.com/repos/simonw/datasette/issues/523 MDEyOklzc3VlQ29tbWVudDUwNDgwOTM5Nw== rixx 2657547 2019-06-24T01:38:14Z 2019-06-24T01:38:14Z CONTRIBUTOR

Ah, apologies – I had found and read those issues, but I was under the impression that they refered only to the filtered row count, not the unfiltered total row count.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show total/unfiltered row count when filtering 459627549  
504807727 https://github.com/simonw/datasette/issues/523#issuecomment-504807727 https://api.github.com/repos/simonw/datasette/issues/523 MDEyOklzc3VlQ29tbWVudDUwNDgwNzcyNw== simonw 9599 2019-06-24T01:24:07Z 2019-06-24T01:24:07Z OWNER

For databases opened in immutable mode we pre-calculate the total row count for every table precisely so we can offer this kind of functionality without too much of a performance hit. The total row count is already available to the template (you can hit the .json endpoint to see it), so implementing this should be possible just by updating the template.

For mutable databases we have a mechanism for attempting the count and giving up after a specified time limit - we can use that to get "3 of many".

It looks like this is actually a dupe of #127 and #134.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show total/unfiltered row count when filtering 459627549  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);