issue_comments

Table actions

4 rows where issue = 530653633 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Mechanism for register_output_renderer to suggest extension or not · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
635054690 https://github.com/simonw/datasette/issues/645#issuecomment-635054690 https://api.github.com/repos/simonw/datasette/issues/645 MDEyOklzc3VlQ29tbWVudDYzNTA1NDY5MA== simonw 9599 2020-05-28T02:22:12Z 2020-05-28T02:22:12Z OWNER

This is a duplicate of a more recent, more developed issue: #770

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for register_output_renderer to suggest extension or not 530653633  
560913459 https://github.com/simonw/datasette/issues/645#issuecomment-560913459 https://api.github.com/repos/simonw/datasette/issues/645 MDEyOklzc3VlQ29tbWVudDU2MDkxMzQ1OQ== simonw 9599 2019-12-02T23:38:22Z 2019-12-02T23:38:22Z OWNER

I'm going to add unit tests for the hook, and as part of that I'll fix the weird thing at the moment where the plugins for the unit tests are defined inside a quoted string as opposed to their own separate file.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for register_output_renderer to suggest extension or not 530653633  
560036740 https://github.com/simonw/datasette/issues/645#issuecomment-560036740 https://api.github.com/repos/simonw/datasette/issues/645 MDEyOklzc3VlQ29tbWVudDU2MDAzNjc0MA== simonw 9599 2019-12-01T01:29:58Z 2019-12-01T01:29:58Z OWNER

It should be optionally awaitable - as should the existing "callback". Can use the same pattern as this one:

https://github.com/simonw/datasette/blob/8c642f04e0608bf537fdd1f76d64c2367fb04d57/datasette/views/base.py#L124-L135

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for register_output_renderer to suggest extension or not 530653633  
560036585 https://github.com/simonw/datasette/issues/645#issuecomment-560036585 https://api.github.com/repos/simonw/datasette/issues/645 MDEyOklzc3VlQ29tbWVudDU2MDAzNjU4NQ== simonw 9599 2019-12-01T01:28:35Z 2019-12-01T01:28:35Z OWNER

Plugins are currently expected to return this: python @hookimpl def register_output_renderer(datasette): return { "extension": "test", "callback": render_test } We can add an optional third argument, "should_suggest", which takes the same arguments as the callback but simply returns True or False depending on if the plugin can work for the current set of data.

If that dictionary key is omitted, Datasette will treat this test as returning True.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for register_output_renderer to suggest extension or not 530653633  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);