issue_comments

Table actions

9 rows where issue = 605110015 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Option to automatically configure based on directory layout · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
620095649 https://github.com/simonw/datasette/issues/731#issuecomment-620095649 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYyMDA5NTY0OQ== simonw 9599 2020-04-27T16:32:44Z 2020-04-27T16:32:44Z OWNER 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
619621388 https://github.com/simonw/datasette/issues/731#issuecomment-619621388 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxOTYyMTM4OA== simonw 9599 2020-04-26T20:38:09Z 2020-04-26T20:38:30Z OWNER

Work now happening in the pull request: https://github.com/simonw/datasette/issues/739

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
619611417 https://github.com/simonw/datasette/issues/731#issuecomment-619611417 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxOTYxMTQxNw== simonw 9599 2020-04-26T19:28:12Z 2020-04-26T19:28:12Z OWNER

I've shipped #648 now, so no reason not to go with the static/ folder as the thing that gets detected and mounted as /static.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
618772317 https://github.com/simonw/datasette/issues/731#issuecomment-618772317 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxODc3MjMxNw== simonw 9599 2020-04-24T02:49:46Z 2020-04-24T02:49:46Z OWNER

Yeah I'll do that. My original thinking on allowing the --static option to mount other things to the root is that it would make it easy for people to add HTML "pages" to their site - like https://www.niche-museums.com/map for example.

But I've proposed a better solution for that here: #648

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
618758326 https://github.com/simonw/datasette/issues/731#issuecomment-618758326 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxODc1ODMyNg== eyeseast 25778 2020-04-24T01:55:00Z 2020-04-24T01:55:00Z CONTRIBUTOR

Mounting ./static at /static seems the simplest way. Saves you the trouble of deciding what else (img for example) gets special treatment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
618155472 https://github.com/simonw/datasette/issues/731#issuecomment-618155472 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxODE1NTQ3Mg== simonw 9599 2020-04-23T03:28:42Z 2020-04-23T03:28:56Z OWNER

As an alternative to --static this could work by letting you create the following:

  • static/css/
  • static/js/

Which would be automatically mounted at /js/... and /css/...

Or maybe just mount static/ at /static/ instead? 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
618126449 https://github.com/simonw/datasette/issues/731#issuecomment-618126449 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxODEyNjQ0OQ== eyeseast 25778 2020-04-23T01:38:55Z 2020-04-23T01:38:55Z CONTRIBUTOR

I've almost suggested this same thing a couple times. I tend to have Makefile (because I'm doing other make stuff anyway to get data prepped), and I end up putting all those CLI options in something like make run. But it would be way easier to just have all those typical options -- plugins, templates, metadata -- be defaults.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
618070791 https://github.com/simonw/datasette/issues/731#issuecomment-618070791 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxODA3MDc5MQ== simonw 9599 2020-04-22T22:21:27Z 2020-04-22T22:21:27Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  
618070541 https://github.com/simonw/datasette/issues/731#issuecomment-618070541 https://api.github.com/repos/simonw/datasette/issues/731 MDEyOklzc3VlQ29tbWVudDYxODA3MDU0MQ== simonw 9599 2020-04-22T22:20:38Z 2020-04-22T22:20:38Z OWNER

I started thinking about this while building https://github.com/simonw/datasette-publish-now

The Vercel hosting platform is built on ASGI - so I need a way to provide an app ASGI object for it to use rather than Datasette's normal pattern of starting up the server using the datasette serve command.

The plugin currently does that by generating an index.py file that looks like this:

python from datasette.app import Datasette import json metadata = dict() try: metadata = json.load(open("metadata.json")) except Exception: pass app = Datasette([], ["fixtures.db"], metadata=metadata).app() But that means I have to replicate the different CLI options - --plugins-dir etc - and figure out how to pass them to the Datasette() constructor.

This would be a whole lot easier if I could use app = Datasette(configure_directory=".") and provide a magically configured instance based on the presence of files in the specified directory.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to automatically configure based on directory layout 605110015  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);