issue_comments

Table actions

6 rows where issue = 613755043 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Support decimal.Decimal type · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
626431484 https://github.com/simonw/sqlite-utils/issues/110#issuecomment-626431484 https://api.github.com/repos/simonw/sqlite-utils/issues/110 MDEyOklzc3VlQ29tbWVudDYyNjQzMTQ4NA== simonw 9599 2020-05-11T01:58:20Z 2020-05-11T01:58:20Z OWNER 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support decimal.Decimal type 613755043  
626391307 https://github.com/simonw/sqlite-utils/issues/110#issuecomment-626391307 https://api.github.com/repos/simonw/sqlite-utils/issues/110 MDEyOklzc3VlQ29tbWVudDYyNjM5MTMwNw== simonw 9599 2020-05-10T21:19:04Z 2020-05-10T21:19:04Z OWNER

I'm going to set it up so that Python decimal.Decimal is treated in a FLOAT column, until someone convinces me otherwise!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support decimal.Decimal type 613755043  
626391217 https://github.com/simonw/sqlite-utils/issues/110#issuecomment-626391217 https://api.github.com/repos/simonw/sqlite-utils/issues/110 MDEyOklzc3VlQ29tbWVudDYyNjM5MTIxNw== simonw 9599 2020-05-10T21:18:28Z 2020-05-10T21:18:28Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support decimal.Decimal type 613755043  
626391063 https://github.com/simonw/sqlite-utils/issues/110#issuecomment-626391063 https://api.github.com/repos/simonw/sqlite-utils/issues/110 MDEyOklzc3VlQ29tbWVudDYyNjM5MTA2Mw== simonw 9599 2020-05-10T21:17:16Z 2020-05-10T21:17:16Z OWNER

From https://www.sqlite.org/datatype3.html#type_affinity :

A column with NUMERIC affinity may contain values using all five storage classes. When text data is inserted into a NUMERIC column, the storage class of the text is converted to INTEGER or REAL (in order of preference) if the text is a well-formed integer or real literal, respectively. If the TEXT value is a well-formed integer literal that is too large to fit in a 64-bit signed integer, it is converted to REAL. For conversions between TEXT and REAL storage classes, only the first 15 significant decimal digits of the number are preserved. If the TEXT value is not a well-formed integer or real literal, then the value is stored as TEXT.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support decimal.Decimal type 613755043  
626390822 https://github.com/simonw/sqlite-utils/issues/110#issuecomment-626390822 https://api.github.com/repos/simonw/sqlite-utils/issues/110 MDEyOklzc3VlQ29tbWVudDYyNjM5MDgyMg== simonw 9599 2020-05-10T21:15:28Z 2020-05-10T21:15:28Z OWNER

https://www.sqlite.org/datatype3.html#affinity_name_examples suggests that DECIMAL(10,5) should be mapped to the SQLite affinity of NUMERIC - which I've not worked with before.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support decimal.Decimal type 613755043  
626390456 https://github.com/simonw/sqlite-utils/issues/110#issuecomment-626390456 https://api.github.com/repos/simonw/sqlite-utils/issues/110 MDEyOklzc3VlQ29tbWVudDYyNjM5MDQ1Ng== simonw 9599 2020-05-10T21:12:40Z 2020-05-10T21:12:40Z OWNER

It definitely makes sense to me that this library should support decimal.Decimal.

Here are the current supported types:

https://github.com/simonw/sqlite-utils/blob/396bee92364fc3a88f6c76969366dd1c4c9c944d/sqlite_utils/db.py#L35-L55

Should decimal.Decimal be stored as a text or float in SQLite I wonder?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support decimal.Decimal type 613755043  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);