issue_comments

Table actions

7 rows where issue = 642388564 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • publish heroku does not work on Windows 10 · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
858831895 https://github.com/simonw/datasette/issues/858#issuecomment-858831895 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDg1ODgzMTg5NQ== rachelmarconi 56045588 2021-06-10T17:44:09Z 2021-06-10T17:44:09Z NONE

any fixes for that recursive issue with temp file? I get it using both heroku and cloudrun, although it seems to still publish and deploy fine

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  
858813675 https://github.com/simonw/datasette/issues/858#issuecomment-858813675 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDg1ODgxMzY3NQ== rachelmarconi 56045588 2021-06-10T17:27:46Z 2021-06-10T17:27:46Z NONE

shell=True is added to line 56 (I guess it used to be 54) of heroku.py as detailed in the original issue. (for posterity)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  
792308036 https://github.com/simonw/datasette/issues/858#issuecomment-792308036 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDc5MjMwODAzNg== robroc 1219001 2021-03-07T16:41:54Z 2021-03-07T16:41:54Z NONE

Apologies if I sound dense but I don't see where you would pass 'shell=True'. I'm using the CLI installed via pip.

On Sun., Mar. 7, 2021, 2:15 a.m. David Smith, notifications@github.com wrote:

To get it to work I had to:

-

add shell=true to the various commands in datasette -

use the name argument of the publish command. ( https://docs.datasette.io/en/stable/publish.html)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/simonw/datasette/issues/858#issuecomment-792230560, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJTOMZMGYSCGUU4J3AVSDTCMRX5ANCNFSM4ODNEDYA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  
792230560 https://github.com/simonw/datasette/issues/858#issuecomment-792230560 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDc5MjIzMDU2MA== smithdc1 39445562 2021-03-07T07:14:58Z 2021-03-07T07:14:58Z NONE

To get it to work I had to:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  
792129022 https://github.com/simonw/datasette/issues/858#issuecomment-792129022 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDc5MjEyOTAyMg== robroc 1219001 2021-03-07T00:23:34Z 2021-03-07T00:23:34Z NONE

@smithdc1 Can you tell us what you did to get it to publish in Windows? What commands did you pass?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  
699690034 https://github.com/simonw/datasette/issues/858#issuecomment-699690034 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDY5OTY5MDAzNA== smithdc1 39445562 2020-09-27T21:23:04Z 2020-09-27T21:23:04Z NONE

Hi Simon,

Thanks so much for all your work on datasette, it's an excellent project and I wish you all the best with it. I particularly enjoyed your talk at the Django London Meetup a short while back.

I've been trying to publish to Heroku from Windows 10 and I was running into this error. I'm not sure why it can't be run without shell=True on Windows but this seems to help. With this change, I am able to publish if I pass in a name to the publish command. When a name is not passed the default of datasette is used and therefore this line here fails (as datasette at heroku already exists) and causes the recession error mentioned above.

https://github.com/simonw/datasette/blob/9a6d0dce282e7fb58c5610e24c74098c923abfdc/datasette/publish/heroku.py#L126

I tried to write a patch for this but I am really struggling with being on Windows (many of the tests seem to fail anyway?), and my lack of knowledge of Mock, so sorry for this. Hope this is of some help. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  
648997857 https://github.com/simonw/datasette/issues/858#issuecomment-648997857 https://api.github.com/repos/simonw/datasette/issues/858 MDEyOklzc3VlQ29tbWVudDY0ODk5Nzg1Nw== simonw 9599 2020-06-24T18:42:10Z 2020-06-24T18:42:10Z OWNER

I really need to get myself a Windows 10 development environment working so I can dig into this kind of bug properly. I have a gaming PC lying around that I could re-task for that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 publish heroku does not work on Windows 10 642388564  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);