issue_comments

Table actions

11 rows where issue = 644582921 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • base_url doesn't seem to work when adding criteria and clicking "apply" · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
726412057 https://github.com/simonw/datasette/issues/865#issuecomment-726412057 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcyNjQxMjA1Nw== simonw 9599 2020-11-12T23:49:23Z 2020-11-12T23:49:23Z OWNER

@tballison thanks, I've split that out into a new issue #1091

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
726385782 https://github.com/simonw/datasette/issues/865#issuecomment-726385782 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcyNjM4NTc4Mg== tballison 6739646 2020-11-12T22:41:06Z 2020-11-12T22:41:06Z NONE

The same is true if I select advanced export and hit the 'export csv' at the bottom of the page.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
726385422 https://github.com/simonw/datasette/issues/865#issuecomment-726385422 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcyNjM4NTQyMg== tballison 6739646 2020-11-12T22:40:14Z 2020-11-12T22:40:14Z NONE

Just tested with the latest Docker image, and it works pretty much everywhere! THANK YOU!

I did notice that if I try to export json or csv, the base is not applied. Not sure if I should reopen this issue or open a new one.

To see this, go here: https://corpora.tika.apache.org/datasette/corpora-metadata/REF_PARSE_EXCEPTION_TYPES

Click/hover over json or CSV and you'll see that the 'datasette' base is not included.

Again, many thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
712597762 https://github.com/simonw/datasette/issues/865#issuecomment-712597762 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcxMjU5Nzc2Mg== simonw 9599 2020-10-20T05:22:59Z 2020-10-20T05:22:59Z OWNER

OK, this is definitely working now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
709633080 https://github.com/simonw/datasette/issues/865#issuecomment-709633080 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcwOTYzMzA4MA== simonw 9599 2020-10-15T22:58:51Z 2020-10-15T22:58:51Z OWNER

It looks like there are places where Datasette might return a redirect that doesn't take base_url into account - I'm planning on fixing those here, after which I think ProxyPassReverse should no longer be necessary. https://github.com/simonw/datasette/issues/1025#issuecomment-709632136

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
709626786 https://github.com/simonw/datasette/issues/865#issuecomment-709626786 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcwOTYyNjc4Ng== simonw 9599 2020-10-15T22:38:38Z 2020-10-15T22:38:38Z OWNER

I managed to recreate proxying using nginx in #1024 - but I could not replicate this bug. I did NOT use ProxyPassReverse though. I think that may be what caused the problem.

I'll add a section to the documentation about this shortly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
709588373 https://github.com/simonw/datasette/issues/865#issuecomment-709588373 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcwOTU4ODM3Mw== simonw 9599 2020-10-15T21:02:31Z 2020-10-15T21:02:31Z OWNER

Tracking ticket: #1023

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
705799046 https://github.com/simonw/datasette/issues/865#issuecomment-705799046 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcwNTc5OTA0Ng== simonw 9599 2020-10-08T20:15:26Z 2020-10-08T20:15:26Z OWNER

Can anyone give me some detailed steps to reproduce for this issue? I think I need to set up my own local nginx or Apache proxy so I can really dig into this and figure out what's going on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
702418045 https://github.com/simonw/datasette/issues/865#issuecomment-702418045 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcwMjQxODA0NQ== simonw 9599 2020-10-01T21:54:00Z 2020-10-01T21:54:00Z OWNER

Had a thought: this is likely to break in plugins too, such as datasette-edit-schema which constructs URLs for redirects e.g. here: https://github.com/simonw/datasette-edit-schema/blob/dbd0abee6dd3385b114cfe9671f7ead1c4855b60/datasette_edit_schema/init.py#L46-L48

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
648998264 https://github.com/simonw/datasette/issues/865#issuecomment-648998264 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDY0ODk5ODI2NA== simonw 9599 2020-06-24T18:43:02Z 2020-06-24T18:43:02Z OWNER

Thanks for the bug report. Yes I think #838 may be the same issue. Will investigate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
648799963 https://github.com/simonw/datasette/issues/865#issuecomment-648799963 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDY0ODc5OTk2Mw== tballison 6739646 2020-06-24T12:51:01Z 2020-06-24T12:51:01Z NONE

This seems to be a duplicate of: https://github.com/simonw/datasette/issues/838

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);