issue_comments

Table actions

5 rows where issue = 653529088 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Consider using enable_callback_tracebacks(True) · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
693001937 https://github.com/simonw/datasette/issues/891#issuecomment-693001937 https://api.github.com/repos/simonw/datasette/issues/891 MDEyOklzc3VlQ29tbWVudDY5MzAwMTkzNw== simonw 9599 2020-09-15T21:58:56Z 2020-09-15T21:58:56Z OWNER

Here's what that looks like: Traceback (most recent call last): File "/Users/simon/Dropbox/Development/datasette/plugins/sql_error.py", line 5, in oh_no_error return 100 / 0 ZeroDivisionError: division by zero ERROR: conn=<sqlite3.Connection object at 0x10bce0030>, sql = 'select oh_no_error()', params = {}: user-defined function raised exception INFO: 127.0.0.1:54066 - "GET /data?sql=select+oh_no_error%28%29 HTTP/1.1" 400 Bad Request

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Consider using enable_callback_tracebacks(True) 653529088  
693000522 https://github.com/simonw/datasette/issues/891#issuecomment-693000522 https://api.github.com/repos/simonw/datasette/issues/891 MDEyOklzc3VlQ29tbWVudDY5MzAwMDUyMg== simonw 9599 2020-09-15T21:55:11Z 2020-09-15T21:55:11Z OWNER

I'm going to turn this on. If people complain about it I can turn it off again (or make it a configuration setting).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Consider using enable_callback_tracebacks(True) 653529088  
692999893 https://github.com/simonw/datasette/issues/891#issuecomment-692999893 https://api.github.com/repos/simonw/datasette/issues/891 MDEyOklzc3VlQ29tbWVudDY5Mjk5OTg5Mw== simonw 9599 2020-09-15T21:53:36Z 2020-09-15T21:53:36Z OWNER

Here's the commit (from 15 years ago) where enable_callback_tracebacks was first added: https://github.com/ghaering/pysqlite/commit/1e8bd36be93b7d7425910642b72e4152c77b0dfd

  • Exceptions in callbacks lead to the query being aborted now instead of silently leading to generating values.
  • Exceptions in callbacks can be echoed to stderr if you call the module level function enable_callback_tracebacks: enable_callback_tracebacks(1).
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Consider using enable_callback_tracebacks(True) 653529088  
692998061 https://github.com/simonw/datasette/issues/891#issuecomment-692998061 https://api.github.com/repos/simonw/datasette/issues/891 MDEyOklzc3VlQ29tbWVudDY5Mjk5ODA2MQ== simonw 9599 2020-09-15T21:49:03Z 2020-09-15T21:49:03Z OWNER

I've been trying to figure out why this is an optional setting that defaults to off.

I think it's because it writes directly to stderr, so the maintainers of sqlite3 reasonably decided that people should be able to opt in to that rather than having weird stuff show up on stderr that they weren't expecting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Consider using enable_callback_tracebacks(True) 653529088  
692968792 https://github.com/simonw/datasette/issues/891#issuecomment-692968792 https://api.github.com/repos/simonw/datasette/issues/891 MDEyOklzc3VlQ29tbWVudDY5Mjk2ODc5Mg== simonw 9599 2020-09-15T20:44:15Z 2020-09-15T20:44:15Z OWNER

https://github.com/peter-wangxu/persist-queue/issues/74 warns that this might not work with PyPy.

I could solve that with: python if hasattr(sqlite3, "enable_callback_tracebacks"): sqlite3.enable_callback_tracebacks(True)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Consider using enable_callback_tracebacks(True) 653529088  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);