issue_comments

Table actions

2 rows where issue = 679650632 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Don't hang in db.execute_write_fn() if connection fails · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
674453772 https://github.com/simonw/datasette/pull/936#issuecomment-674453772 https://api.github.com/repos/simonw/datasette/issues/936 MDEyOklzc3VlQ29tbWVudDY3NDQ1Mzc3Mg== codecov[bot] 22429695 2020-08-15T22:35:29Z 2020-08-15T22:35:29Z NONE

Codecov Report

Merging #936 into main will increase coverage by 0.02%. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #936 +/-

========================================== + Coverage 84.02% 84.04% +0.02%
========================================== Files 28 28
Lines 3774 3774
========================================== + Hits 3171 3172 +1
+ Misses 603 602 -1
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/app.py | 96.18% <0.00%> (+0.18%) | :arrow_up: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13b3b51...94a68b9. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't hang in db.execute_write_fn() if connection fails 679650632  
674453318 https://github.com/simonw/datasette/pull/936#issuecomment-674453318 https://api.github.com/repos/simonw/datasette/issues/936 MDEyOklzc3VlQ29tbWVudDY3NDQ1MzMxOA== simonw 9599 2020-08-15T22:29:15Z 2020-08-15T22:32:58Z OWNER

Test failure: ``` tests/test_canned_queries.py F

captured stdout >>> enter traceback >>>

canned_write_client = <datasette.utils.testing.TestClient object at 0x108ec5040>

def test_insert(canned_write_client):
    response = canned_write_client.post(
        "/data/add_name",
        {"name": "Hello"},
        allow_redirects=False,
        csrftoken_from=True,
        cookies={"foo": "bar"},
    )
    assert 302 == response.status

  assert "/data/add_name?success" == response.headers["Location"]

E AssertionError: assert '/data/add_name?success' == '/data/add_name' E - /data/add_name E + /data/add_name?success E ? ++++++++

/Users/simon/Dropbox/Development/datasette/tests/test_canned_queries.py:66: AssertionError ``` No idea why this change would affect that test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't hang in db.execute_write_fn() if connection fails 679650632  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);