issue_comments

Table actions

3 rows where issue = 705057955 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Add --tar option to "datasette publish heroku" · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
705874457 https://github.com/simonw/datasette/issues/969#issuecomment-705874457 https://api.github.com/repos/simonw/datasette/issues/969 MDEyOklzc3VlQ29tbWVudDcwNTg3NDQ1Nw== simonw 9599 2020-10-08T23:27:30Z 2020-10-08T23:27:30Z OWNER

For the moment I'm going to ship this as the --tar= option. Can consider detecting gtar in the future.

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
 Add --tar option to "datasette publish heroku" 705057955  
705874317 https://github.com/simonw/datasette/issues/969#issuecomment-705874317 https://api.github.com/repos/simonw/datasette/issues/969 MDEyOklzc3VlQ29tbWVudDcwNTg3NDMxNw== simonw 9599 2020-10-08T23:27:00Z 2020-10-08T23:27:00Z OWNER

I'm working on this now. Just ran this test and it worked (no longer showed my the warning message).

datasette publish heroku fixtures.db -n datasette-issue-999 --branch=main --tar=/usr/local/bin/gtar

But... I wonder if it should automatically do this if it detects that gtar is available?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add --tar option to "datasette publish heroku" 705057955  
696788109 https://github.com/simonw/datasette/issues/969#issuecomment-696788109 https://api.github.com/repos/simonw/datasette/issues/969 MDEyOklzc3VlQ29tbWVudDY5Njc4ODEwOQ== simonw 9599 2020-09-22T15:15:14Z 2020-09-22T15:15:14Z OWNER

I don't think a standard "pass these extra arguments to the publish tool" mechanism will work because there's no guarantee that a publisher uses a CLI tool - or if it does, it might make several calls to different CLI tools. The Cloud Run one runs a couple of commands, as illustrated by this test:

https://github.com/simonw/datasette/blob/a648bb82bac201c7658f6fdb499ff8ac17ebd2e8/tests/test_publish_cloudrun.py#L63-L73

Adding a --tar option for datasette publish heroku is a good fix for this though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add --tar option to "datasette publish heroku" 705057955  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);