issue_comments

Table actions

6 rows where issue = 753767911 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Support for generated columns · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
736088949 https://github.com/simonw/datasette/pull/1117#issuecomment-736088949 https://api.github.com/repos/simonw/datasette/issues/1117 MDEyOklzc3VlQ29tbWVudDczNjA4ODk0OQ== nattaylor 2789593 2020-11-30T22:15:58Z 2020-11-30T22:23:19Z NONE

I just deployed this and its working great.

~In a very unscientific benchmark my response times went from around 22-25ms to 33-36ms, but I didn't even dig enough to confirm the latency is related to the change. It's on a VPS, so maybe the load changed.~ I don't see any difference in performance.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support for generated columns 753767911  
736067475 https://github.com/simonw/datasette/pull/1117#issuecomment-736067475 https://api.github.com/repos/simonw/datasette/issues/1117 MDEyOklzc3VlQ29tbWVudDczNjA2NzQ3NQ== codecov[bot] 22429695 2020-11-30T21:28:22Z 2020-11-30T21:28:22Z NONE

Codecov Report

Merging #1117 (ccdf2c6) into main (dea3c50) will decrease coverage by 0.00%. The diff coverage is 95.23%.

```diff @@ Coverage Diff @@

main #1117 +/-

========================================== - Coverage 91.48% 91.48% -0.01%
========================================== Files 30 31 +1
Lines 3841 3852 +11
========================================== + Hits 3514 3524 +10
- Misses 327 328 +1
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/utils/__init__.py | 94.10% <87.50%> (-0.20%) | :arrow_down: | | datasette/utils/sqlite.py | 100.00% <100.00%> (ø) | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dea3c50...ccdf2c6. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support for generated columns 753767911  
736029337 https://github.com/simonw/datasette/pull/1117#issuecomment-736029337 https://api.github.com/repos/simonw/datasette/issues/1117 MDEyOklzc3VlQ29tbWVudDczNjAyOTMzNw== simonw 9599 2020-11-30T20:39:06Z 2020-11-30T20:39:06Z OWNER

Here's the problem: https://www.sqlite.org/changes.html#version_3_26_0

2018-12-01 (3.26.0)

CI is running 3.22.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support for generated columns 753767911  
736028726 https://github.com/simonw/datasette/pull/1117#issuecomment-736028726 https://api.github.com/repos/simonw/datasette/issues/1117 MDEyOklzc3VlQ29tbWVudDczNjAyODcyNg== simonw 9599 2020-11-30T20:37:50Z 2020-11-30T20:37:50Z OWNER

This kind of problem is why I have a tmate workflow:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support for generated columns 753767911  
736023089 https://github.com/simonw/datasette/pull/1117#issuecomment-736023089 https://api.github.com/repos/simonw/datasette/issues/1117 MDEyOklzc3VlQ29tbWVudDczNjAyMzA4OQ== simonw 9599 2020-11-30T20:26:27Z 2020-11-30T20:26:27Z OWNER

On my laptop: platform darwin -- Python 3.8.6, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 SQLite: 3.33.0 In CI they are all SQLite: 3.22.0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support for generated columns 753767911  
736018609 https://github.com/simonw/datasette/pull/1117#issuecomment-736018609 https://api.github.com/repos/simonw/datasette/issues/1117 MDEyOklzc3VlQ29tbWVudDczNjAxODYwOQ== simonw 9599 2020-11-30T20:17:31Z 2020-11-30T20:17:31Z OWNER

I need to replicate these failures on my laptop. My hunch is that this is down to the version of SQLite available to Python.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support for generated columns 753767911  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);