issue_comments

Table actions

8 rows where issue = 760621356 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Establish pattern for release branches to support bug fixes · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
742023111 https://github.com/simonw/datasette/issues/1136#issuecomment-742023111 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAyMzExMQ== simonw 9599 2020-12-09T20:17:02Z 2020-12-09T20:17:02Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742022222 https://github.com/simonw/datasette/issues/1136#issuecomment-742022222 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAyMjIyMg== simonw 9599 2020-12-09T20:15:24Z 2020-12-09T20:15:51Z OWNER

Used this procedure for the first time for 0.52.5 - deploy run here: https://github.com/simonw/datasette/actions/runs/411465648 - PyPI release here: https://pypi.org/project/datasette/0.52.5/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742017622 https://github.com/simonw/datasette/issues/1136#issuecomment-742017622 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAxNzYyMg== simonw 9599 2020-12-09T20:06:47Z 2020-12-09T20:06:47Z OWNER

Then I can ship the release directly from that branch, creating the tag as part of the release process:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742014881 https://github.com/simonw/datasette/issues/1136#issuecomment-742014881 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAxNDg4MQ== simonw 9599 2020-12-09T20:01:27Z 2020-12-09T20:01:27Z OWNER

I'll write the release notes in the branch, then cherry-pick them over to main.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742014366 https://github.com/simonw/datasette/issues/1136#issuecomment-742014366 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAxNDM2Ng== simonw 9599 2020-12-09T20:00:35Z 2020-12-09T20:00:35Z OWNER

Actually I'll start from 0.52.4 and then cherry-pick the fixes.

git branch 0.52.x 0.52.4
git checkout 0.52.x
git cherry-pick COMMIT

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742009294 https://github.com/simonw/datasette/issues/1136#issuecomment-742009294 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAwOTI5NA== simonw 9599 2020-12-09T19:51:18Z 2020-12-09T19:51:18Z OWNER

Likewise, Read The Docs publishes as stable the docs from the latest tagged release, so I would expect that to work fine as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742009101 https://github.com/simonw/datasette/issues/1136#issuecomment-742009101 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAwOTEwMQ== simonw 9599 2020-12-09T19:50:53Z 2020-12-09T19:50:53Z OWNER

My concern is if this will break anything about CI. I don't think it will - the code that deploys the latest main to https://latest.datasette.io/ should be unaffected, and the checkout code in publish.yml should check out the correct code based on the tag used for that release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742008087 https://github.com/simonw/datasette/issues/1136#issuecomment-742008087 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAwODA4Nw== simonw 9599 2020-12-09T19:48:56Z 2020-12-09T19:48:56Z OWNER

I think I'm going to create a branch called 0.52.x that starts with 8ae0f9f7f0d644b0161165a1084f53acd2786f7c and then tag the release from there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);