issue_comments

Table actions

10 rows where issue = 903986178 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Test Datasette Docker images built for different architectures · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
849820019 https://github.com/simonw/datasette/issues/1344#issuecomment-849820019 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgyMDAxOQ== simonw 9599 2021-05-27T17:44:39Z 2021-05-27T17:52:58Z OWNER

This pattern appears to work, executed at the root of a checkout of datasette: docker run -it -v `pwd`:/mnt --platform linux/amd64 \ datasetteproject/datasette:0.57a1 bash -c ' pip install "pytest>=5.2.2,<6.3.0" \ "pytest-xdist>=2.2.1,<2.3" \ "pytest-asyncio>=0.10,<0.16" \ "beautifulsoup4>=4.8.1,<4.10.0" \ "black==21.5b1" \ "pytest-timeout>=1.4.2,<1.5" \ "trustme>=0.7,<0.8" \ && cd /mnt && pytest'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849815361 https://github.com/simonw/datasette/issues/1344#issuecomment-849815361 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgxNTM2MQ== simonw 9599 2021-05-27T17:36:51Z 2021-05-27T17:36:51Z OWNER

To run the test suite... need to install a few more dependencies: https://github.com/simonw/datasette/blob/7b106e106000713bbee31b34d694b3dadbd4818c/setup.py#L71-L79

And then mount the tests/ folder into the container and run pytest.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849806581 https://github.com/simonw/datasette/issues/1344#issuecomment-849806581 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwNjU4MQ== simonw 9599 2021-05-27T17:22:37Z 2021-05-27T17:34:27Z OWNER

~ % docker run -it --platform linux/arm/v7 -v `pwd`:/mnt -p 8001:8001 datasetteproject/datasette:0.57a1 python -c 'import platform; print(platform.uname())' Unable to find image 'datasetteproject/datasette:0.57a1' locally 0.57a1: Pulling from datasetteproject/datasette ee0a2cc24f29: Pull complete ca231153300d: Pull complete 6073fc53d406: Pull complete bb2a6a6421dd: Pull complete 14c15f441034: Pull complete 28d113f72ba5: Pull complete 40516c2c3785: Pull complete Digest: sha256:8dd469efa0b34b9e946c4e91496fc7bec702efec9c0f5ec548ccd4030f3263b2 Status: Downloaded newer image for datasetteproject/datasette:0.57a1 uname_result(system='Linux', node='c2e1a05732ed', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='armv7l') Shorter version: ~ % docker run -it --platform linux/ppc64le datasetteproject/datasette:0.57a1 python -c 'import platform; print(platform.uname())' Unable to find image 'datasetteproject/datasette:0.57a1' locally 0.57a1: Pulling from datasetteproject/datasette c840eb5e9aed: Pull complete fc17d8b577ec: Pull complete 712a0ad995f8: Pull complete 56101149914c: Pull complete e6241dfe9d38: Pull complete 41ed85039888: Pull complete 26beeabe9213: Pull complete Digest: sha256:8dd469efa0b34b9e946c4e91496fc7bec702efec9c0f5ec548ccd4030f3263b2 Status: Downloaded newer image for datasetteproject/datasette:0.57a1 uname_result(system='Linux', node='0fe85887fa30', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='ppc64le') ~ %

OK! Now I need to figure out how to run the full test suite on each one, then I can call this done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849805778 https://github.com/simonw/datasette/issues/1344#issuecomment-849805778 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwNTc3OA== simonw 9599 2021-05-27T17:21:11Z 2021-05-27T17:21:22Z OWNER

This helps: ~ % docker run -it --platform linux/s390x -v `pwd`:/mnt \ -p 8001:8001 datasetteproject/datasette:0.57a1 \ python -c 'import platform; print(platform.uname())' uname_result(system='Linux', node='d14916ca91df', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='s390x')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849804684 https://github.com/simonw/datasette/issues/1344#issuecomment-849804684 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwNDY4NA== simonw 9599 2021-05-27T17:19:16Z 2021-05-27T17:19:16Z OWNER

Having pushed that to Docker Hub the following seems to work on my laptop:

docker run --platform linux/s390x \
  -v `pwd`:/mnt -p 8001:8001 \
  datasetteproject/datasette:0.57a1 datasette -p 8001 -h 0.0.0.0

I'd like to confirm that this is correctly emulating the architecture and running the correct published image though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849801969 https://github.com/simonw/datasette/issues/1344#issuecomment-849801969 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwMTk2OQ== simonw 9599 2021-05-27T17:14:49Z 2021-05-27T17:14:49Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849797767 https://github.com/simonw/datasette/issues/1344#issuecomment-849797767 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc5Nzc2Nw== simonw 9599 2021-05-27T17:08:13Z 2021-05-27T17:08:13Z OWNER

Related issue: #1272 - being able to run the test suite inside Docker inside GitHub Actions would be incredibly helpful here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849793312 https://github.com/simonw/datasette/issues/1344#issuecomment-849793312 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc5MzMxMg== simonw 9599 2021-05-27T17:01:16Z 2021-05-27T17:01:16Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849788412 https://github.com/simonw/datasette/issues/1344#issuecomment-849788412 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc4ODQxMg== simonw 9599 2021-05-27T16:53:28Z 2021-05-27T16:53:28Z OWNER

(Should also update https://docs.datasette.io/en/stable/contributing.html#release-process with notes on how this works)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  
849788159 https://github.com/simonw/datasette/issues/1344#issuecomment-849788159 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc4ODE1OQ== simonw 9599 2021-05-27T16:53:04Z 2021-05-27T16:53:04Z OWNER

I'm going to release a 0.57a1 alpha to Docker Hub using the new buildx mechanism.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Test Datasette Docker images built for different architectures 903986178  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);