home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

10 rows where issue = 965143346 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

  • simonw 9
  • codecov[bot] 1

author_association 2

  • OWNER 9
  • NONE 1

issue 1

  • Add reference page to documentation using Sphinx autodoc · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
896162082 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896162082 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41alki codecov[bot] 22429695 2021-08-10T17:10:39Z 2021-08-10T23:07:35Z NONE

Codecov Report

Merging #312 (43bc064) into main (ee469e3) will decrease coverage by 0.02%. The diff coverage is 96.84%.

```diff @@ Coverage Diff @@

main #312 +/-

========================================== - Coverage 96.30% 96.28% -0.03%
========================================== Files 5 5
Lines 2168 2179 +11
========================================== + Hits 2088 2098 +10
- Misses 80 81 +1
```

| Impacted Files | Coverage Δ | | |---|---|---| | sqlite_utils/db.py | 97.91% <96.84%> (-0.08%) | :arrow_down: |


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee469e3...43bc064. Read the comment docs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896284722 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896284722 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41bDgy simonw 9599 2021-08-10T20:08:03Z 2021-08-10T20:08:21Z OWNER

Spotted a rogue backtick:

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896200682 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896200682 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41au_q simonw 9599 2021-08-10T18:03:40Z 2021-08-10T18:03:40Z OWNER

Adding type signatures to create_table() and .create_table_sql() is a bit too involved, I'll do that in a separate issue.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896186025 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896186025 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41arap simonw 9599 2021-08-10T17:42:51Z 2021-08-10T17:42:51Z OWNER

That worked! https://sqlite-utils.datasette.io/en/autodoc/reference.html

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896182934 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896182934 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41aqqW simonw 9599 2021-08-10T17:38:44Z 2021-08-10T17:38:44Z OWNER

From https://docs.readthedocs.io/en/stable/config-file/v2.html#packages it looks like I can tell Read The Docs to run pip install -e . using a .readthedocs.yaml configuration:

```yaml version: 2

sphinx: configuration: docs/conf.py

python: version: "3.9" install: - method: pip path: . extra_requirements: - docs ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896180956 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896180956 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41aqLc simonw 9599 2021-08-10T17:35:51Z 2021-08-10T17:35:51Z OWNER

Reading the rest of https://sphinx-rtd-tutorial.readthedocs.io/en/latest/sphinx-config.html#autodoc-configuration it suggests using a requirements.txt file to install dependencies - but I use setup.py for that so I need to figure out a different pattern here.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896175438 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896175438 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41ao1O simonw 9599 2021-08-10T17:28:19Z 2021-08-10T17:28:19Z OWNER

https://sphinx-rtd-tutorial.readthedocs.io/en/latest/sphinx-config.html#autodoc-configuration says do something like this at the top of conf.py:

python import os import sys sys.path.insert(0, os.path.abspath('../../simpleble/'))

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896174456 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896174456 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41aol4 simonw 9599 2021-08-10T17:27:01Z 2021-08-10T17:27:01Z OWNER

Docs are now building at https://sqlite-utils.datasette.io/en/autodoc/reference.html

But there's a problem! The page is semi-blank:

I need to teach Read The Docs how to ensure sqlite_utils is available for introspection.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896156971 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896156971 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41akUr simonw 9599 2021-08-10T17:04:22Z 2021-08-10T17:05:59Z OWNER

I'm going to get Read The Docs to build the docs for this branch too - on https://readthedocs.org/projects/sqlite-utils/versions/ I am clicking this button:

I then set it to "active" (so pushes to the branch will build it) and "hidden" (so it wouldn't show up in search or in the navigation menu). https://docs.readthedocs.io/en/stable/versions.html#version-states

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  
896154028 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896154028 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41ajms simonw 9599 2021-08-10T17:01:06Z 2021-08-10T17:01:06Z OWNER

On Python 3.6:

sqlite_utils/db.py:366: in Database def tables(self) -> List[Table]: E NameError: name 'Table' is not defined Python 3.7 can fix this with from __future__ import annotations but since we still support 3.6 I'll have to use a string instead.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add reference page to documentation using Sphinx autodoc 965143346  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 22.833ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows