issues: 1926729132

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
1926729132 PR_kwDOCGYnMM5b7Z_y 598 Fixed issue #433 - CLI eats cursor 62745 closed 0     2 2023-10-04T18:06:58Z 2023-11-04T00:46:55Z 2023-11-04T00:40:30Z CONTRIBUTOR simonw/sqlite-utils/pulls/598

The issue is that underlying iterator is not fully consumed within the body of the with file_progress() block. Instead, that block creates generator expressions like docs = (dict(zip(headers, row)) for row in reader)

These iterables are consumed later, outside the with file_progress() block, which consumes the underlying iterator, and in turn updates the progress bar.

This means that the ProgressBar.__exit__ method gets called before the last time the ProgressBar.update method gets called. The result is that the code to make the cursor invisible (inside the update() method) is called after the cleanup code to make it visible (in the __exit__ method).

The fix is to move consumption of the docs iterators within the progress bar block. (

(An additional fix, to make ProgressBar more robust against this kind of misuse, would to make it refusing to update after its __exit__ method had been called, just like files cannot be read() after they are closed. That requires a in the click library).

Note that Github diff obscures the simplicity of this diff, it's just indenting a block of code.

:books: Documentation preview :books:: https://sqlite-utils--598.org.readthedocs.build/en/598/

 140912432 pull     
{
    "url": "https://api.github.com/repos/simonw/sqlite-utils/issues/598/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
 0  

Links from other tables