home / github

Menu
  • Search all tables
  • GraphQL API

issues

Table actions
  • GraphQL API for issues

21 rows where milestone = 5971510 and state = "closed" sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, comments, author_association, created_at (date), updated_at (date), closed_at (date)

type 2

  • issue 19
  • pull 2

state 1

  • closed · 21 ✖

repo 1

  • datasette 21
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
717783692 MDU6SXNzdWU3MTc3ODM2OTI= 1002 Release notes for Datasette 0.50 simonw 9599 closed 0   Datasette 0.50 5971510 1 2020-10-09T01:45:00Z 2020-10-09T17:52:54Z 2020-10-09T17:52:53Z OWNER  

https://github.com/simonw/datasette/compare/0.49.1...c12b7a5def7028845a54a9fdac4052a87a0a8bb8

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1002/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
681375466 MDU6SXNzdWU2ODEzNzU0NjY= 943 await datasette.client.get(path) mechanism for executing internal requests simonw 9599 closed 0   Datasette 0.50 5971510 33 2020-08-18T22:17:42Z 2020-10-09T17:22:55Z 2020-10-09T16:11:26Z OWNER  

datasette-graphql works by making internal requests to the TableView class (in order to take advantage of existing pagination logic, plus options like ?_search= and ?_where=) - see #915

I want to support a mod_rewrite style mechanism for putting nicer URLs on top of Datasette pages - I botched that together for a project here using an internal ASGI proxying trick: https://github.com/natbat/tidepools_near_me/commit/ec102c6da5a5d86f17628740d90b6365b671b5e1

If the datasette object provided a documented method for executing internal requests (in a way that makes sense with logging etc - i.e. doesn't get logged as a separate request) both of these use-cases would be much neater.

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/943/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
718264811 MDU6SXNzdWU3MTgyNjQ4MTE= 1006 Documentation for datasette.client simonw 9599 closed 0   Datasette 0.50 5971510 2 2020-10-09T16:09:02Z 2020-10-09T17:22:31Z 2020-10-09T17:20:37Z OWNER  

I'm going to document this in a separate issue.

Originally posted by @simonw in https://github.com/simonw/datasette/pull/1000#issuecomment-706269271

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1006/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
718255803 MDU6SXNzdWU3MTgyNTU4MDM= 1004 Replace MockRequest with Request.fake() simonw 9599 closed 0   Datasette 0.50 5971510 0 2020-10-09T15:55:28Z 2020-10-09T16:26:24Z 2020-10-09T16:26:24Z OWNER  

This code: https://github.com/simonw/datasette/blob/7249ac5ca04b5ddc6517750326ee7e522cc49145/tests/utils.py#L1-L8

Predates the introduction of this class method: https://github.com/simonw/datasette/blob/7249ac5ca04b5ddc6517750326ee7e522cc49145/datasette/utils/asgi.py#L108-L121

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1004/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
717746043 MDExOlB1bGxSZXF1ZXN0NTAwMjU2NDg1 1000 datasette.client internal requests mechanism simonw 9599 closed 0 simonw 9599 Datasette 0.50 5971510 18 2020-10-08T23:58:25Z 2020-10-09T16:11:26Z 2020-10-09T16:11:25Z OWNER simonw/datasette/pulls/1000

Refs #943

datasette 107914493 pull    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1000/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
0  
717768441 MDU6SXNzdWU3MTc3Njg0NDE= 1001 OPTIONS requests return a 500 error simonw 9599 closed 0   Datasette 0.50 5971510 8 2020-10-09T00:57:13Z 2020-10-09T01:44:41Z 2020-10-09T01:43:58Z OWNER  

``` % curl -vv -XOPTIONS https://latest.datasette.io/ * Trying 216.58.195.83:443...

OPTIONS / HTTP/1.1 Host: latest.datasette.io User-Agent: curl/7.70.0 Accept: /

  • Mark bundle as not supporting multiuse < HTTP/1.1 500 Internal Server Error ```
datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1001/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
716988478 MDU6SXNzdWU3MTY5ODg0Nzg= 997 Documentation covering buildpack deployment simonw 9599 closed 0   Datasette 0.50 5971510 3 2020-10-08T03:21:52Z 2020-10-08T23:56:03Z 2020-10-08T23:32:10Z OWNER  

A tidied up version of https://til.simonwillison.net/til/til/digitalocean_datasette-on-digitalocean-app-platform.md - but mention that you can deploy to Heroku using the same mechanism.

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/997/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
705057955 MDU6SXNzdWU3MDUwNTc5NTU= 969 Add --tar option to "datasette publish heroku" betatim 1448859 closed 0   Datasette 0.50 5971510 3 2020-09-20T06:54:53Z 2020-10-08T23:55:59Z 2020-10-08T23:30:59Z NONE  

This issue is about how best to pass additional options to tools used for publishing datasettes. A concrete example is wanting to pass the --tar flag to the heroku CLI tool. I think there are at least two options for doing this: documentation for each publishing tool to explain how to set flags via env variables (if possible) or building a mechanism that lets users pass additional flags through datasette.

When using datasette publish heroku binder-launches.db --extra-options="--config facet_time_limit_ms:35000 --config sql_time_limit_ms:35000" --name=binderlytics --install=datasette-vega to publish https://binderlytics.herokuapp.com/ the following error happens:

``` › Warning: heroku update available from 7.42.1 to 7.43.0. › Warning: heroku update available from 7.42.1 to 7.43.0. › Warning: heroku update available from 7.42.1 to 7.43.0. Setting WEB_CONCURRENCY and restarting ⬢ binderlytics... done, v13 WEB_CONCURRENCY: 1 › Warning: heroku update available from 7.42.1 to 7.43.0. ▸ Couldn't detect GNU tar. Builds could fail due to decompression errors ▸ See https://devcenter.heroku.com/articles/platform-api-deploying-slugs#create-slug-archive ▸ Please install it, or specify the '--tar' option ▸ Falling back to node's built-in compressor buffer.js:358 throw new ERR_INVALID_OPT_VALUE.RangeError('size', size); ^

RangeError [ERR_INVALID_OPT_VALUE]: The value "3303763968" is invalid for option "size" at Function.alloc (buffer.js:367:3) at new Buffer (buffer.js:281:19) at Readable.<anonymous> (/Users/thead/.local/share/heroku/node_modules/archiver-utils/index.js:39:15) at Readable.emit (events.js:322:22) at endReadableNT (/Users/thead/.local/share/heroku/node_modules/readable-stream/lib/_stream_readable.js:1010:12) at processTicksAndRejections (internal/process/task_queues.js:84:21) { code: 'ERR_INVALID_OPT_VALUE' } ```

After installing GNU tar with brew install gnu-tar and modifying datasette/publish/heroku.py to include the --tar=/path/to/gnu-tar publishing works.

I think the problem occurs once your heroku slug reaches a certain size. At least when I add only a few 100 entries to the datasette then the error does not occcur.

datasette version 0.49.1 OSX 10.14.6 (18G103)

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/969/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
459397625 MDU6SXNzdWU0NTkzOTc2MjU= 514 Documentation with recommendations on running Datasette in production without using Docker chrismp 7936571 closed 0   Datasette 0.50 5971510 27 2019-06-21T22:48:12Z 2020-10-08T23:55:53Z 2020-10-08T23:33:05Z NONE  

I've got some SQLite databases too big to push to Heroku or the other services with built-in support in datasette.

So instead I moved my datasette code and databases to a remote server on Kimsufi. In the folder containing the SQLite databases I run the following code.

nohup datasette serve -h 0.0.0.0 *.db --cors --port 8000 --metadata metadata.json > output.log 2>&1 &.

When I go to http://my-remote-server.com:8000, the site loads. But I know this is not a good long-term solution to running datasette on this server.

What is the "correct" way to have this site run, preferably on server port 80?

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/514/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
717729056 MDU6SXNzdWU3MTc3MjkwNTY= 999 Datasette should default to running Uvicorn with workers=1 simonw 9599 closed 0   Datasette 0.50 5971510 3 2020-10-08T23:07:03Z 2020-10-08T23:55:46Z 2020-10-08T23:21:36Z OWNER  

Uvicorn uses the WEB_CONCURRENCY variable, if set, to specify the number of workers to use.

Datasette does not work with options for this other than 1:

WEB_CONCURRENCY=2 datasette . WARNING: You must pass the application as an import string to enable 'reload' or 'workers'. This was the cause of the Heroku bug in #627.

I fixed that issue by setting WEB_CONCURRENCY=1 in datasette publish heroku, but a better fix would be to hard-code workers=1 in Datasette itself.

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/999/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
716756082 MDU6SXNzdWU3MTY3NTYwODI= 996 Better handling of multiple matching template wildcard paths simonw 9599 closed 0   Datasette 0.50 5971510 3 2020-10-07T18:25:40Z 2020-10-08T23:55:41Z 2020-10-07T22:51:17Z OWNER  

I tried building this:

templates/pages/{topic}.html
templates/pages/{topic}/{slug}.html

And it didn't work - hits to /foo/bar which should have been rendered by the {slug}.html template were instead rendered by the top level {topic.html} template.

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/996/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
715779909 MDExOlB1bGxSZXF1ZXN0NDk4NjMwNzA4 995 Document setting Google Cloud SDK properties ghing 110420 closed 0   Datasette 0.50 5971510 2 2020-10-06T15:18:01Z 2020-10-08T23:55:30Z 2020-10-06T16:25:38Z CONTRIBUTOR simonw/datasette/pulls/995

Document setting Google Cloud SDK properties to avoid having to respond to interactive prompts when running datasette publish cloudrun.

datasette 107914493 pull    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/995/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
0  
715072935 MDU6SXNzdWU3MTUwNzI5MzU= 993 Column action menu should show column type simonw 9599 closed 0   Datasette 0.50 5971510 2 2020-10-05T18:40:49Z 2020-10-08T23:55:19Z 2020-10-06T00:33:15Z OWNER  

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/993/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
713304417 MDU6SXNzdWU3MTMzMDQ0MTc= 989 Column action sort descending/ascending links should remove _next= pagination simonw 9599 closed 0   Datasette 0.50 5971510 0 2020-10-02T02:33:48Z 2020-10-08T23:55:15Z 2020-10-04T18:05:28Z OWNER  

On page https://latest.datasette.io/fixtures/sortable?_next=15%2Cg%2Cz&_sort=sortable clicking on sortable_with_nulls > sort_ascending links to https://latest.datasette.io/fixtures/sortable?_next=15%2Cg%2Cz&_sort_desc=sortable_with_nulls - which doesn't make sense.

Changing the sort order needs to reset to the first page.

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/989/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
712839383 MDU6SXNzdWU3MTI4MzkzODM= 985 Column actions should support facet by compound primary keys simonw 9599 closed 0   Datasette 0.50 5971510 1 2020-10-01T13:21:57Z 2020-10-08T23:55:11Z 2020-10-01T16:50:41Z OWNER  

On https://latest.datasette.io/fixtures/compound_three_primary_keys the column action menu doesn't display for the pk1, pk2 and pk3 columns (because they are primary keys) even though faceting by them is actually useful.

Refs #98

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/985/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
711627628 MDU6SXNzdWU3MTE2Mjc2Mjg= 981 Action menu for table columns simonw 9599 closed 0   Datasette 0.50 5971510 16 2020-09-30T04:45:38Z 2020-10-08T23:55:00Z 2020-09-30T23:58:17Z OWNER  

At the very least I'd like a menu on each table column that lets me select sort-asc v.s. sort-desc without having to click twice.

I'd also like to be able to indicate that a column should be used for faceting (possibly only for columns that are not floating point and do not have a unique index on them).

This needs to be built with accessibility in mind - I don't want screenreaders to read out the contents of a menu as the "th" label for any given cell.

Related: #690

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/981/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
710819020 MDU6SXNzdWU3MTA4MTkwMjA= 980 Another rendering glitch with column headers on mobile simonw 9599 closed 0   Datasette 0.50 5971510 2 2020-09-29T06:53:13Z 2020-10-08T23:54:49Z 2020-09-29T19:21:50Z OWNER  

Similar to #978.

https://latest-with-plugins.datasette.io/fixtures?sql=select%0D%0A++dateutil_rrule(%27FREQ%3DHOURLY%3BCOUNT%3D5%27)%2C%0D%0A++dateutil_rrule_date(%0D%0A++++%27FREQ%3DDAILY%3BCOUNT%3D3%27%2C%0D%0A++++%271st+jan+2020%27%0D%0A++)%3B

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/980/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
710506708 MDU6SXNzdWU3MTA1MDY3MDg= 978 Rendering glitch with column headings on mobile simonw 9599 closed 0   Datasette 0.50 5971510 6 2020-09-28T19:04:45Z 2020-10-08T23:54:40Z 2020-09-28T22:43:01Z OWNER  

https://latest-with-plugins.datasette.io/fixtures?sql=select%0D%0A++dateutil_parse%28%2210+october+2020+3pm%22%29%2C%0D%0A++dateutil_easter%28%222020%22%29%2C%0D%0A++dateutil_parse_fuzzy%28%22This+is+due+10+september%22%29%2C%0D%0A++dateutil_parse%28%221%2F2%2F2020%22%29%2C%0D%0A++dateutil_parse%28%222020-03-04%22%29%2C%0D%0A++dateutil_parse_dayfirst%28%222020-03-04%22%29%2C%0D%0A++dateutil_easter%282020%29

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/978/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
706486323 MDU6SXNzdWU3MDY0ODYzMjM= 973 'bool' object is not callable error simonw 9599 closed 0   Datasette 0.50 5971510 2 2020-09-22T15:30:54Z 2020-10-08T23:54:32Z 2020-09-22T15:40:35Z OWNER  

I'm getting this when latest is deployed to Cloud Run: Traceback (most recent call last): File "/usr/local/bin/datasette", line 8, in <module> sys.exit(cli()) File "/usr/local/lib/python3.8/site-packages/click/core.py", line 829, in __call__ return self.main(*args, **kwargs) File "/usr/local/lib/python3.8/site-packages/click/core.py", line 782, in main rv = self.invoke(ctx) File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/local/lib/python3.8/site-packages/click/core.py", line 610, in invoke return callback(*args, **kwargs) File "/usr/local/lib/python3.8/site-packages/datasette/cli.py", line 406, in serve inspect_data = json.load(open(inspect_file)) TypeError: 'bool' object is not callable I think I may have broken things in #970 - a980199e61fe7ccf02c2123849d86172d2ae54ff

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/973/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
705108492 MDU6SXNzdWU3MDUxMDg0OTI= 970 request an "-o" option on "datasette server" to open the default browser at the running url secretGeek 2861690 closed 0   Datasette 0.50 5971510 4 2020-09-20T13:16:34Z 2020-10-08T23:54:27Z 2020-09-22T14:27:04Z NONE  

This is a request for a "convenience" feature, and only a nice to have. It's based on seeing this feature in several little command line hypertext server apps.

If you run, for example:

datasette.exe serve --open "mydb.s3db"

I would like it if default browser is launched, at the URL that is being served.

The angular cli does this, for example

ng serve <project> --open #see https://angular.io/cli/serve

...as does my usual mini web server of choice when inspecting local static files....

npx http-server -o # see https://www.npmjs.com/package/http-server

Just a tiny thing. Love your work!

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/970/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed
653529088 MDU6SXNzdWU2NTM1MjkwODg= 891 Consider using enable_callback_tracebacks(True) simonw 9599 closed 0   Datasette 0.50 5971510 5 2020-07-08T19:07:16Z 2020-10-08T23:54:23Z 2020-09-15T21:59:27Z OWNER  

From https://docs.python.org/3/library/sqlite3.html#sqlite3.enable_callback_tracebacks

sqlite3.``enable_callback_tracebacks(flag)¶

By default you will not get any tracebacks in user-defined functions, aggregates, converters, authorizer callbacks etc. If you want to debug them, you can call this function with flag set to True. Afterwards, you will get tracebacks from callbacks on sys.stderr. Use False to disable the feature again.

Maybe turn this on for all of Datasette? Are there any disadvantages to doing that?

datasette 107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/891/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [pull_request] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
, [active_lock_reason] TEXT, [performed_via_github_app] TEXT, [reactions] TEXT, [draft] INTEGER, [state_reason] TEXT);
CREATE INDEX [idx_issues_repo]
                ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
                ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
                ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
                ON [issues] ([user]);
Powered by Datasette · Queries took 82.118ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows