pull_requests: 575187457

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association repo url merged_by auto_merge
575187457 MDExOlB1bGxSZXF1ZXN0NTc1MTg3NDU3 1229 closed 0 ensure immutable databses when starting in configuration directory mode with 295329 fixes #1224 This PR ensures all databases found in a configuration directory that match the files in `inspect-data.json` will be set to `immutable` as outlined in https://docs.datasette.io/en/latest/settings.html#configuration-directory-mode specifically on building the `datasette` instance it checks: - if `immutables` is an empty tuple - as passed by the cli code - if `immutables` is the default function value `None` - when it's not explicitly set And correctly builds the immutable database list from the `inspect-data[file]` keys. Note for this to work the `inspect-data.json` file must contain `file` paths which are relative to the configuration directory otherwise the file paths won't match and the dbs won't be set to immutable. I couldn't find an easy way to test this due to the way `make_app_client` works, happy to take directions on adding a test for this. I've updated the relevant docs as well, i.e. use the `inspect` cli cmd from the config directory path to create the relevant file ``` cd $config_dir datasette inspect *.db --inspect-file=inspect-data.json ``` https://docs.datasette.io/en/latest/performance.html#using-datasette-inspect 2021-02-17T20:18:26Z 2022-04-22T13:16:36Z 2021-03-29T00:17:32Z 2021-03-29T00:17:31Z f92d823766872a6fd7e76c5249a6b2de1ab0f447     0 a095248ad18c9c5272dbd52f4c97ea8a36cf91f3 8e18c7943181f228ce5ebcea48deb59ce50bee1f CONTRIBUTOR 107914493 https://github.com/simonw/datasette/pull/1229    

Links from other tables