issue_comments

Table actions

7 rows where author_association = "CONTRIBUTOR" and issue = 1102899312 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Add new spatialite helper methods · 7 ✖

author_association 1

  • CONTRIBUTOR · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1030002502 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1030002502 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49ZJdG eyeseast 25778 2022-02-04T13:50:19Z 2022-02-04T13:50:19Z CONTRIBUTOR

Awesome. Thanks for your help getting it in. Will now look at adding CLI versions of this. It's going to be super helpful on a bunch of my projects.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  
1029370537 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029370537 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49WvKp eyeseast 25778 2022-02-03T20:25:58Z 2022-02-03T20:25:58Z CONTRIBUTOR

OK, I moved all the GIS helpers into db.py as methods on Database and Table, and I put find_spatialite back in utils.py. I deleted gis.py, since there's nothing left it. Docs and tests are updated and passing.

I think this is better.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  
1029338360 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029338360 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49WnT4 eyeseast 25778 2022-02-03T19:43:56Z 2022-02-03T19:43:56Z CONTRIBUTOR

Works for me. I was just looking at how the FTS extensions work and they're just methods, too. So this can be consistent with that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  
1029326568 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029326568 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49Wkbo eyeseast 25778 2022-02-03T19:28:26Z 2022-02-03T19:28:26Z CONTRIBUTOR

from sqlite_utils.utils import find_spatialite is part of the documented API already:

https://sqlite-utils.datasette.io/en/3.22.1/python-api.html#finding-spatialite

To avoid needing to bump the major version number to 4 to indicate a backwards incompatible change, we should keep a from .gis import find_spatialite line at the top of utils.py such that any existing code with that documented import continues to work.

This is fixed now. I had to take out the type annotations for Database and Table to avoid a circular import, but that's fine and may be moot if these become class methods.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  
1029306428 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029306428 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49Wfg8 eyeseast 25778 2022-02-03T19:03:43Z 2022-02-03T19:03:43Z CONTRIBUTOR

I thought about adding these as methods on Database and Table, and I'm back and forth on it for the same reasons you are. It's certainly cleaner, and it's clearer what you're operating on. I could go either way.

I do sort of like having all the Spatialite stuff in its own module, just because it's built around an extension you might not have or want, but I don't know if that's a good reason to have a different API.

You could have init_spatialite add methods to Database and Table, so they're only there if you have Spatialite set up. Is that too clever? It feels too clever.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  
1029180984 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029180984 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49WA44 eyeseast 25778 2022-02-03T16:42:04Z 2022-02-03T16:42:04Z CONTRIBUTOR

Fixed my spelling. That's a useful thing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  
1029175907 https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029175907 https://api.github.com/repos/simonw/sqlite-utils/issues/385 IC_kwDOCGYnMM49V_pj eyeseast 25778 2022-02-03T16:36:54Z 2022-02-03T16:36:54Z CONTRIBUTOR

@simonw Not sure if you've seen this, but any chance you can run the tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new spatialite helper methods 1102899312  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);