issue_comments

Table actions

3 rows where issue = 1075893249 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Custom pages don't work on windows · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1028535868 https://github.com/simonw/datasette/issues/1545#issuecomment-1028535868 https://api.github.com/repos/simonw/datasette/issues/1545 IC_kwDOBm6k_c49TjY8 simonw 9599 2022-02-03T02:08:30Z 2022-02-03T02:08:30Z OWNER

Filed an issue with Jinja suggesting a documentation update: - https://github.com/pallets/jinja/issues/1578

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages don't work on windows 1075893249  
1028517268 https://github.com/simonw/datasette/issues/1545#issuecomment-1028517268 https://api.github.com/repos/simonw/datasette/issues/1545 IC_kwDOBm6k_c49Te2U simonw 9599 2022-02-03T01:26:53Z 2022-02-03T01:26:53Z OWNER

I understand the problem now! https://github.com/pallets/jinja/issues/1378#issuecomment-812410922

Jinja template names/paths are not always filesystem paths. So regardless of the OS Jinja always uses forward slashes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages don't work on windows 1075893249  
997462604 https://github.com/simonw/datasette/issues/1545#issuecomment-997462604 https://api.github.com/repos/simonw/datasette/issues/1545 IC_kwDOBm6k_c47dBJM simonw 9599 2021-12-19T21:17:08Z 2021-12-19T21:17:08Z OWNER

Here's the relevant code: https://github.com/simonw/datasette/blob/4094741c2881c2ada3f3f878b532fdaec7914953/datasette/app.py#L1204-L1219

It's using route_path.split("/") which should be OK because that's the incoming request.path path - which I would expect to use / even on Windows. Then it uses os.path.join which should do the right thing.

I need to get myself a proper Windows development environment setup to investigate this one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Custom pages don't work on windows 1075893249  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);