issue_comments

Table actions

5 rows where issue = 421548881 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 5 ✖

issue 1

  • Hashed URLs should be optional · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
493109347 https://github.com/simonw/datasette/issues/418#issuecomment-493109347 https://api.github.com/repos/simonw/datasette/issues/418 MDEyOklzc3VlQ29tbWVudDQ5MzEwOTM0Nw== simonw 9599 2019-05-16T15:12:26Z 2019-05-16T15:12:26Z OWNER

I'm ready to close this now thanks to fixing #471 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Hashed URLs should be optional 421548881  
491551702 https://github.com/simonw/datasette/issues/418#issuecomment-491551702 https://api.github.com/repos/simonw/datasette/issues/418 MDEyOklzc3VlQ29tbWVudDQ5MTU1MTcwMg== simonw 9599 2019-05-11T23:32:21Z 2019-05-11T23:32:21Z OWNER

I'm going to re-open this, because some of this needs revisiting now that we aren't running .inspect() and hence are not calculating hashes for anything other than immutable databases (and databases are treated as mutable by default).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Hashed URLs should be optional 421548881  
491551647 https://github.com/simonw/datasette/issues/418#issuecomment-491551647 https://api.github.com/repos/simonw/datasette/issues/418 MDEyOklzc3VlQ29tbWVudDQ5MTU1MTY0Nw== simonw 9599 2019-05-11T23:31:23Z 2019-05-11T23:31:23Z OWNER

Actually right now https://latest.datasette.io/fixtures/facetable?_hash=1 redirects to https://latest.datasette.io/fixtures-000/facetable - because we are no longer calculating hashes on startup for non-immutable databases. So that's weird.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Hashed URLs should be optional 421548881  
473724868 https://github.com/simonw/datasette/issues/418#issuecomment-473724868 https://api.github.com/repos/simonw/datasette/issues/418 MDEyOklzc3VlQ29tbWVudDQ3MzcyNDg2OA== simonw 9599 2019-03-17T23:07:31Z 2019-03-17T23:07:31Z OWNER

The design of this feature is discussed extensively in the comments on pull request #416

Some demos:

``` ~ $ curl -i 'https://latest.datasette.io/fixtures-dd88475/facetable' HTTP/2 200 date: Sun, 17 Mar 2019 23:05:21 GMT content-type: text/html; charset=utf-8 content-length: 17555 cache-control: max-age=31536000

</html>~ $ curl -i 'https://latest.datasette.io/fixtures/facetable' HTTP/2 200 date: Sun, 17 Mar 2019 23:05:40 GMT content-type: text/html; charset=utf-8 content-length: 17410 cache-control: max-age=5 ```

There are now three config settings relevant to the above:

default_cache_ttl - defaults to 5s. The default cache TTL for non-hashed resources. default_cache_ttl_hashed - defaults to 31536000s. The default cache TTL for hashed resources. hash_urls - defaults to False. If True, all URLs will attempt to redirect to their hashed version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Hashed URLs should be optional 421548881  
473709815 https://github.com/simonw/datasette/issues/418#issuecomment-473709815 https://api.github.com/repos/simonw/datasette/issues/418 MDEyOklzc3VlQ29tbWVudDQ3MzcwOTgxNQ== simonw 9599 2019-03-17T20:08:31Z 2019-03-17T20:08:31Z OWNER

In #419 I'm now proposing that Datasette default to opening files in "mutable" mode, in which case it would not make sense to support hash URLs for those files at all. So actually this feature will only be available for files that are explicitly opened in immutable mode.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Hashed URLs should be optional 421548881  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);