issue_comments

Table actions

9 rows where issue = 629595228 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • New WIP writable canned queries · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
638257697 https://github.com/simonw/datasette/pull/796#issuecomment-638257697 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODI1NzY5Nw== simonw 9599 2020-06-03T15:05:07Z 2020-06-03T15:05:07Z OWNER

I'm going to document this, land it and then continue to work on the other pieces - CSRF protection and .json mode - in separate tickets.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638249652 https://github.com/simonw/datasette/pull/796#issuecomment-638249652 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODI0OTY1Mg== simonw 9599 2020-06-03T14:51:29Z 2020-06-03T14:51:51Z OWNER

Consider this one: "delete_name": { "sql": "delete from names where rowid = :rowid", "write": True, "on_success_message": "Name deleted", }, If the user enters an invalid rowid the query will still execute without errors and hence the success message will still be displayed. Can I address this?

Maybe allow an optional "rowcount_expected": 1 property? And if that count isn't matched treat the query as an error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638241738 https://github.com/simonw/datasette/pull/796#issuecomment-638241738 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODI0MTczOA== simonw 9599 2020-06-03T14:38:45Z 2020-06-03T14:38:45Z OWNER

Violating a unique constraint will throw an error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638241366 https://github.com/simonw/datasette/pull/796#issuecomment-638241366 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODI0MTM2Ng== simonw 9599 2020-06-03T14:38:03Z 2020-06-03T14:38:31Z OWNER

Maybe I need some kind of optional validation mechanism? SQLite lets me insert text or floating point numbers into integer columns right now, which feels wrong.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638240919 https://github.com/simonw/datasette/pull/796#issuecomment-638240919 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODI0MDkxOQ== simonw 9599 2020-06-03T14:37:22Z 2020-06-03T14:37:22Z OWNER

I'm having trouble coming up with a canned SQL query that will only error with certain parameters, which I need in order to test out the on_error_redirect and on_error_message properties.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638238144 https://github.com/simonw/datasette/pull/796#issuecomment-638238144 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODIzODE0NA== simonw 9599 2020-06-03T14:32:54Z 2020-06-03T14:33:11Z OWNER

I'm going to have on_success_redirect and on_error_redirect properties for specifying where the redirect should go too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638188196 https://github.com/simonw/datasette/pull/796#issuecomment-638188196 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODE4ODE5Ng== simonw 9599 2020-06-03T13:13:27Z 2020-06-03T14:32:27Z OWNER

"Query executed" is the default message, but it's pretty bland:

How about letting queries define custom success messages in their metadata configuration?

"on_success_message" and "on_error_message"

How can the system tell if an "update" query was actually successful? Maybe I should expose .rowcount somehow, so I can report back on how many rows were updated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638206851 https://github.com/simonw/datasette/pull/796#issuecomment-638206851 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODIwNjg1MQ== simonw 9599 2020-06-03T13:44:29Z 2020-06-03T13:44:29Z OWNER

Default message is now "Query executed, 1 row affected" as of https://github.com/simonw/datasette/pull/796/commits/f45c44ac8f3a9a2182d76c6bda44a06676499e4b

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  
638205923 https://github.com/simonw/datasette/pull/796#issuecomment-638205923 https://api.github.com/repos/simonw/datasette/issues/796 MDEyOklzc3VlQ29tbWVudDYzODIwNTkyMw== simonw 9599 2020-06-03T13:43:12Z 2020-06-03T13:43:12Z OWNER

For .json mode (when the URL has a .json suffix) I'm going to handle both form-encoded and JSON encoded inputs and return a 200 status code with JSON that tells you if the query executed successfully and how many rows were affected.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New WIP writable canned queries 629595228  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);