issue_comments

Table actions

3 rows where issue = 838245338 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Unit tests for the Dockerfile · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1199115002 https://github.com/simonw/datasette/issues/1272#issuecomment-1199115002 https://api.github.com/repos/simonw/datasette/issues/1272 IC_kwDOBm6k_c5HeQr6 xmichele 37748899 2022-07-29T10:22:58Z 2022-07-29T10:22:58Z NONE

test_dockerfile.py

I'm skipping this for the moment because the new Dockerfile shape introduced in #1249 (comment) isn't compatible with this technique, since it installs Datasette from PyPI rather than directly from the repo.

Will need to change that if I want to do this unit tests thing.

Hello, can't you copy in a later step directly in the output directory, e.g. COPY test_dockerfile.py /usr/lib/python*/.. or something like that ? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Unit tests for the Dockerfile 838245338  
808648974 https://github.com/simonw/datasette/issues/1272#issuecomment-808648974 https://api.github.com/repos/simonw/datasette/issues/1272 MDEyOklzc3VlQ29tbWVudDgwODY0ODk3NA== simonw 9599 2021-03-27T04:29:42Z 2021-03-27T04:29:42Z OWNER

I'm skipping this for the moment because the new Dockerfile shape introduced in https://github.com/simonw/datasette/issues/1249#issuecomment-804404544 isn't compatible with this technique, since it installs Datasette from PyPI rather than directly from the repo.

Will need to change that if I want to do this unit tests thing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Unit tests for the Dockerfile 838245338  
808647937 https://github.com/simonw/datasette/issues/1272#issuecomment-808647937 https://api.github.com/repos/simonw/datasette/issues/1272 MDEyOklzc3VlQ29tbWVudDgwODY0NzkzNw== simonw 9599 2021-03-27T04:23:19Z 2021-03-27T04:23:36Z OWNER

Part of the challenge here is only running if a Docker daemon is available. I think this pattern works, in tests/test_dockerfile.py: ```python import httpx import pathlib import pytest import subprocess

root = pathlib.Path(file).parent.parent

def docker_is_available(): try: client = httpx.Client( transport=httpx.HTTPTransport(uds="/var/run/docker.sock") ) client.get("http://docker/info") return True except httpx.ConnectError: return False

@pytest.fixture def build_container(): assert (root / "Dockerfile").exists() subprocess.check_call([ "docker", "build", str(root), "-t", "datasette-dockerfile-test" ])

@pytest.mark.skipif(not docker_is_available(), reason="Docker is not available" ) def test_dockerfile(build_container): output = subprocess.check_output([ "docker", "run", "datasette-dockerfile-test", "datasette", "--get", "/_memory?sql=select+1&shape=_array" ]) assert False, "Implement better assertion here" ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Unit tests for the Dockerfile 838245338  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);